Use Django's last_executed_query to quote SQL #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously string values were not quoted, causing sqlparse to interpret them as code. Any value which matched a SQL keyword would be capitalized and indented, causing garbled display of queries containing text like 'of', 'and', 'key', 'limit', etc. django.db.backends.BaseDatabaseOperations has a helpful last_executed_query method which expands query placeholders (django-debug-toolbar also uses this) reliably. This commit changes the SQL realtime module to use last_executed_query and to perform the formatting after the actual query executes to match the expected semantics. Closes dcramer#13
|
(Pardon the mess: I would have tied this into #13 but Github's API is returning 500s or 422s for a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously string values were not quoted, causing sqlparse to interpret them
as code. Any value which matched a SQL keyword would be capitalized and
indented, causing garbled display of queries containing text like 'of',
'and', 'key',
'limit', etc.
django.db.backends.BaseDatabaseOperations has a helpful last_executed_query
method which expands query placeholders (django-debug-toolbar also uses this)
reliably. This commit changes the SQL realtime module to use
last_executed_query and to perform the formatting after the actual query
executes to match the expected semantics.
Closes #13