Skip to content

Commit 7ec81fa

Browse files
author
Pere Urbon-Bayes
committed
Remove traces and references the meta logstash gem and change it to use the new logstash-core gem.
1 parent b8bf074 commit 7ec81fa

File tree

3 files changed

+15
-25
lines changed

3 files changed

+15
-25
lines changed

Gemfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
source 'https://rubygems.org'
2-
gemspec
3-
gem "logstash", :github => "elasticsearch/logstash", :branch => "1.5"
2+
gemspec

README.md

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Need help? Try #logstash on freenode IRC or the logstash-users@googlegroups.com
2222
#### Code
2323
- To get started, you'll need JRuby with the Bundler gem installed.
2424

25-
- Create a new plugin or clone and existing from the GitHub [logstash-plugins](https://github.com/logstash-plugins) organization.
25+
- Create a new plugin or clone and existing from the GitHub [logstash-plugins](https://github.com/logstash-plugins) organization. We also provide [example plugins](https://github.com/logstash-plugins?query=example).
2626

2727
- Install dependencies
2828
```sh
@@ -31,40 +31,29 @@ bundle install
3131

3232
#### Test
3333

34-
```sh
35-
bundle exec rspec
36-
```
34+
- Update your dependencies
3735

38-
The Logstash code required to run the tests/specs is specified in the `Gemfile` by the line similar to:
39-
```ruby
40-
gem "logstash", :github => "elasticsearch/logstash", :branch => "1.5"
41-
```
42-
To test against another version or a local Logstash, edit the `Gemfile` to specify an alternative location, for example:
43-
```ruby
44-
gem "logstash", :github => "elasticsearch/logstash", :ref => "master"
45-
```
46-
```ruby
47-
gem "logstash", :path => "/your/local/logstash"
36+
```sh
37+
bundle install
4838
```
4939

50-
Then update your dependencies and run your tests:
40+
- Run tests
5141

5242
```sh
53-
bundle install
5443
bundle exec rspec
5544
```
5645

5746
### 2. Running your unpublished Plugin in Logstash
5847

5948
#### 2.1 Run in a local Logstash clone
6049

61-
- Edit Logstash `tools/Gemfile` and add the local plugin path, for example:
50+
- Edit Logstash `Gemfile` and add the local plugin path, for example:
6251
```ruby
6352
gem "logstash-filter-awesome", :path => "/your/local/logstash-filter-awesome"
6453
```
65-
- Update Logstash dependencies
54+
- Install plugin
6655
```sh
67-
rake vendor:gems
56+
bin/plugin install --no-verify
6857
```
6958
- Run Logstash with your plugin
7059
```sh
@@ -74,6 +63,8 @@ At this point any modifications to the plugin code will be applied to this local
7463

7564
#### 2.2 Run in an installed Logstash
7665

66+
You can use the same **2.1** method to run your plugin in an installed Logstash by editing its `Gemfile` and pointing the `:path` to your local plugin development directory or you can build the gem and install it using:
67+
7768
- Build your plugin gem
7869
```sh
7970
gem build logstash-filter-awesome.gemspec
@@ -90,6 +81,6 @@ All contributions are welcome: ideas, patches, documentation, bug reports, compl
9081

9182
Programming is not a required skill. Whatever you've seen about open source and maintainers or community members saying "send patches or die" - you will not see that here.
9283

93-
It is more important to me that you are able to contribute.
84+
It is more important to the community that you are able to contribute.
9485

95-
For more information about contributing, see the [CONTRIBUTING](https://github.com/elasticsearch/logstash/blob/master/CONTRIBUTING.md) file.
86+
For more information about contributing, see the [CONTRIBUTING](https://github.com/elasticsearch/logstash/blob/master/CONTRIBUTING.md) file.

logstash-output-tcp.gemspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Gem::Specification.new do |s|
22

33
s.name = 'logstash-output-tcp'
4-
s.version = '0.1.3'
4+
s.version = '0.1.4'
55
s.licenses = ['Apache License (2.0)']
66
s.summary = "Write events over a TCP socket."
77
s.description = "This gem is a logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/plugin install gemname. This gem is not a stand-alone program"
@@ -20,7 +20,7 @@ Gem::Specification.new do |s|
2020
s.metadata = { "logstash_plugin" => "true", "logstash_group" => "output" }
2121

2222
# Gem dependencies
23-
s.add_runtime_dependency 'logstash', '>= 1.4.0', '< 2.0.0'
23+
s.add_runtime_dependency "logstash-core", '>= 1.4.0', '< 2.0.0'
2424

2525
s.add_runtime_dependency 'logstash-codec-json'
2626
s.add_runtime_dependency 'stud'

0 commit comments

Comments
 (0)