Change MaxConcurrentItems to MaxConcurrentWorkflows. Make feature specific to WorkflowConsumer only.

Author: Eddie Wood

src/WorkflowCore/Models/WorkflowOptions.cs

@@ -8,7 +8,7 @@ namespace WorkflowCore.Models
 {
     public class WorkflowOptions
     {
-        internal static readonly int MinimumNumberOfConcurrentItems = 2;
+        internal static readonly int MinimumNumberOfConcurrentWorkflows = 2;
 
         internal Func<IServiceProvider, IPersistenceProvider> PersistanceFactory;
         internal Func<IServiceProvider, IQueueProvider> QueueFactory;
@@ -18,7 +18,7 @@ public class WorkflowOptions
         internal TimeSpan PollInterval;
         internal TimeSpan IdleTime;
         internal TimeSpan ErrorRetryInterval;
-        internal int? MaxConcurrentItems;
+        internal int? MaxConcurrentWorkflows;
 
         public IServiceCollection Services { get; private set; }
 
@@ -71,14 +71,14 @@ public void UseErrorRetryInterval(TimeSpan interval)
             ErrorRetryInterval = interval;
         }
 
-        public void UseMaxConcurrentItems(int? maxConcurrentItems)
+        public void UseMaxConcurrentWorkflows(int? maxConcurrentWorkflows)
         {
-            if (maxConcurrentItems.HasValue && maxConcurrentItems.Value < MinimumNumberOfConcurrentItems)
+            if (maxConcurrentWorkflows.HasValue && maxConcurrentWorkflows.Value < MinimumNumberOfConcurrentWorkflows)
             {
-                throw new ArgumentOutOfRangeException($"If {nameof(maxConcurrentItems)} is specified, it cannot be less than ${MinimumNumberOfConcurrentItems}.");
+                throw new ArgumentOutOfRangeException($"If {nameof(maxConcurrentWorkflows)} is specified, it cannot be less than ${MinimumNumberOfConcurrentWorkflows}.");
             }
 
-            MaxConcurrentItems = maxConcurrentItems;
+            MaxConcurrentWorkflows = maxConcurrentWorkflows;
         }
     }
 

src/WorkflowCore/Services/BackgroundTasks/EventConsumer.cs

@@ -13,7 +13,7 @@ internal class EventConsumer : QueueConsumer, IBackgroundTask
         private readonly IPersistenceProvider _persistenceStore;
         private readonly IDistributedLockProvider _lockProvider;
         private readonly IDateTimeProvider _datetimeProvider;
-        protected override int MaxConcurrentItems => WorkflowOptions.MinimumNumberOfConcurrentItems;
+        protected override int MaxConcurrentItems => 2;
         protected override QueueType Queue => QueueType.Event;
 
         public EventConsumer(IPersistenceProvider persistenceStore, IQueueProvider queueProvider, ILoggerFactory loggerFactory, IServiceProvider serviceProvider, IWorkflowRegistry registry, IDistributedLockProvider lockProvider, WorkflowOptions options, IDateTimeProvider datetimeProvider)

src/WorkflowCore/Services/BackgroundTasks/QueueConsumer.cs

@@ -11,7 +11,7 @@ namespace WorkflowCore.Services.BackgroundTasks
     internal abstract class QueueConsumer : IBackgroundTask
     {
         protected abstract QueueType Queue { get; }
-        protected virtual int MaxConcurrentItems => Options.MaxConcurrentItems ?? Math.Max(Environment.ProcessorCount, WorkflowOptions.MinimumNumberOfConcurrentItems);
+        protected virtual int MaxConcurrentItems => Math.Max(Environment.ProcessorCount, 2);
         protected virtual bool EnableSecondPasses => false;
 
         protected readonly IQueueProvider QueueProvider;

src/WorkflowCore/Services/BackgroundTasks/WorkflowConsumer.cs

@@ -15,6 +15,8 @@ internal class WorkflowConsumer : QueueConsumer, IBackgroundTask
         private readonly ObjectPool<IPersistenceProvider> _persistenceStorePool;
         private readonly ObjectPool<IWorkflowExecutor> _executorPool;
 
+        protected override int MaxConcurrentItems => Options.MaxConcurrentWorkflows ?? base.MaxConcurrentItems;
+
         protected override QueueType Queue => QueueType.Workflow;
 
         public WorkflowConsumer(IPooledObjectPolicy<IPersistenceProvider> persistencePoolPolicy, IQueueProvider queueProvider, ILoggerFactory loggerFactory, IServiceProvider serviceProvider, IWorkflowRegistry registry, IDistributedLockProvider lockProvider, IPooledObjectPolicy<IWorkflowExecutor> executorPoolPolicy, IDateTimeProvider datetimeProvider, WorkflowOptions options)