Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrary shadow with inset not merged correctly #391

Closed
dcastil opened this issue Mar 15, 2024 · 2 comments · Fixed by #392
Closed

Arbitrary shadow with inset not merged correctly #391

dcastil opened this issue Mar 15, 2024 · 2 comments · Fixed by #392
Labels
bug Something isn't working context-v2 Related to tailwind-merge v2

Comments

@dcastil
Copy link
Owner

dcastil commented Mar 15, 2024

Same here with arbitrary values: shadow-[inset_0_1px_0,inset_0_-1px_0] shadow-[hsl(var(--border-primary))]

Originally posted by @Sliov in #277 (comment)
@dcastil dcastil added bug Something isn't working context-v2 Related to tailwind-merge v2 labels Mar 15, 2024
@dcastil dcastil mentioned this issue Mar 15, 2024
Closed
@dcastil
Copy link
Owner Author

dcastil commented Mar 15, 2024

The problem is that the shadowRegex in https://github.com/dcastil/tailwind-merge/blob/v2.2.1/src/lib/validators.ts#L9 doesn't account for inset.

@dcastil dcastil mentioned this issue Mar 16, 2024
Merged
@github-actions GitHub Actions
Copy link

This was addressed in release v2.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working context-v2 Related to tailwind-merge v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix arbitrary shadow with inset not recognized dcastil/tailwind-merge
1 participant
@dcastil