Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14 Validation related issue #27

Open
nemrutco opened this issue Feb 11, 2020 · 0 comments
Open

#14 Validation related issue #27

nemrutco opened this issue Feb 11, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@nemrutco
Copy link

nemrutco commented Feb 11, 2020

Another issue related to #14
when password field is nullable, it submits password to db as null and db updates the value to null (db password field is nullable) but when i use without ConditionalContainer, null value does not update db so old password stays. Why does it updates db when field is submit empty? it should ignore the field.

Password::make(__('Password'), 'password')
                    ->onlyOnForms()
                    ->creationRules('required', 'string', 'min:8')
                    ->updateRules('sometimes', 'nullable', 'string', 'min:8')

I am not sure why but sometimes does not work. Not sure if it's Nova's bug or this package's

@milewski milewski added the bug Something isn't working label Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant