Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heatmap box-title should be updated on redraw #798

Merged
merged 3 commits into from
Apr 3, 2015
Merged

Heatmap box-title should be updated on redraw #798

merged 3 commits into from
Apr 3, 2015

Conversation

hhravn
Copy link
Contributor

@hhravn hhravn commented Dec 16, 2014

When the chart is redrawn, the title attached to the individual boxes should update as well.

@gordonwoodhull
Copy link
Contributor

I think this got accidentally included in your other PR #794. Could you remove it from that one please?

Also a simple jasmine test that falls before this change, would be very much appreciated.

@gordonwoodhull
Copy link
Contributor

Thanks, this is a pretty new component and it will be great to have basic functionality working properly for 2.0

@gordonwoodhull gordonwoodhull added this to the v2.0 milestone Dec 16, 2014
gordonwoodhull added a commit that referenced this pull request Apr 3, 2015
reverted in PR #794, needed in PR #798
@gordonwoodhull gordonwoodhull merged commit 600dd48 into dc-js:master Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants