Alternate approach to Ordinal Brushing #1809
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach makes a key assumption that brushing makes logical sense only if the underlying data has a defined order.
In this approach:
The brushing and re-sorting, in my opinion, do not go well together. For example, if there is a selection and the data get re-sorted (for example because of activities on the other charts), the selection will now include different items, which may not be intended. In my opinion, unless there is a natural ordering in the data, range brushing does not make logical sense.