Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evadeDomainFilter with elasticY causes lines to be clipped #1431

Open
kum-deepak opened this issue May 6, 2018 · 2 comments
Open

evadeDomainFilter with elasticY causes lines to be clipped #1431

kum-deepak opened this issue May 6, 2018 · 2 comments

Comments

@kum-deepak
Copy link
Collaborator

It seems elasticY considers only the visible part of the chart to calculate minimum/maximum domain values. When combined with evadeDomainFilter lines may get outside the chart area.

See the attached screen grab from http://dc-js.github.io/dc.js/examples/range-series.html

dc js series example

@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented May 7, 2018

This is a result of #1376 - we do want to use only the visible part of the graph to determine min / max Y. We don't want to squish the display just because there is some really large point way off the canvas.

But I think it's a little more complicated than what that PR implemented. We need to consider points just barely outside the X domain.

Technically we'd want to intersect the lines with the vertical lines at the domain start and end, and min / max over those intersection points as well as the points within the domain. But it would probably be good enough to include one point on each side which is just outside the X domain.

Interestingly, this is related to the correct solution for the problem which evadeDomainFilter fixes stupidly. #949 also suggests including just one point outside the domain.

@kum-deepak
Copy link
Collaborator Author

Maybe we can go onto this one after completing the composite brushing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants