-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SoftwareSerial renewal #26
Conversation
based on ArduinoCore-avr 1.8.3 code (https://github.com/arduino/ArduinoCore-avr/tree/1.8.3/libraries/SoftwareSerial/src). There is significant difference between pre-1.6.0 and after-1.6.1. - added stopListening() method - removed delay table, use <util/delay_basic.h> with calculated delays from CPU clock
Impressive! Will do some testing this weekend and merge it. |
Here is the results of test before submitting pull request.
|
FYI, there is the diff with ArduinoCore-avr 1.8.3's code at https://pastebin.com/VRuLqcWa |
Yes, it is based on an older Arduino core. As stated in the readme, my starting point was Larduino_HSP v3.6c (the most Arduino compatible I found) which is 3 years old. Looking forward to see what else you optimise! I'm working in making the new release with all extra pull requests and a bunch of improvements at once, so it will take me a bit longer. |
@dbuezas Are you planning to make sure to not break existing functionality? That would be really appreciated. :) |
Of course :)
…On Sun, 19 Jul 2020, 18:02 Stephan Eisfeld, ***@***.***> wrote:
@dbuezas <https://github.com/dbuezas> Are you planning to make sure to
not break existing functionality? That would be really appreciated. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF5X3AGD2JHJXBKFVQ3PBLR4MKKNANCNFSM4O63JKIQ>
.
|
@jg1uaa, the new SoftwareSerial is 438 bytes smaller!
And 300 baud doesn't even work in the HW Serial |
I want to use the LG8F328P board as an alternative for the arduino nano to make a 6 channel DMX-controller. The library DMXSerial seems not compatible with the board. |
@tandy1 |
Many Thanks for the answer.I started a new discusion with the information.
6 channel DMX controller with · Discussion #226 · dbuezas/lgt8fx (github.com)
On Tuesday, 20 December 2022 at 18:18:56 WET, LaZsolt ***@***.***> wrote:
@tandy1
It doesn't seem like a (software)serial communication problem. Could you provide more hardware and software details?
Please start a new discussion with this topic. https://github.com/dbuezas/lgt8fx/discussions
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
based on ArduinoCore-avr 1.8.3 code (https://github.com/arduino/ArduinoCore-avr/tree/1.8.3/libraries/SoftwareSerial/src).
There is significant difference between pre-1.6.0 and after-1.6.1.
from CPU clock
Some libraries (for example, RadioLib https://github.com/jgromes/RadioLib) requires stopListening() method so renewal of SoftwareSerial is mandatory.
And different from ATmega328P, LGT8F328P's SBIW instruction takes 1 clock (ATmega328P takes 2 clocks). This means we need to adjust _delay_loop_2() in <util/delay_basic.h> for lgt8fx. Currently SoftwareSerial.cpp has own _delay_loop_2() implementation.