Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update global configs for v 1.1 #1319

Merged
merged 14 commits into from
Apr 14, 2022
Merged

Update global configs for v 1.1 #1319

merged 14 commits into from
Apr 14, 2022

Conversation

runleonarun
Copy link
Collaborator

@runleonarun runleonarun commented Apr 9, 2022

closes #1102

Description & motivation

This PR:

  • Alphabetizes the CLI flags
  • Add the new --quiet flag and config.

Pre-release docs

Is this change related to an unreleased version of dbt?

  • No: please ensure the base branch is current
  • Unsure: we'll let you know!

Checklist

If you added new pages (delete if not applicable):

  • The page has been added to website/sidebars.js
  • The new page has a unique filename

If you removed existing pages (delete if not applicable):

  • The page has been removed from website/sidebars.js
  • An entry has been added to _redirects

@runleonarun runleonarun requested a review from annafil as a code owner April 9, 2022 01:22
@netlify
Copy link

netlify bot commented Apr 9, 2022

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 0b15453
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/6258681beffbff0008c60e55
😎 Deploy Preview https://deploy-preview-1319--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@runleonarun runleonarun added the dbt-core v1.1 Docs impact for the v1.1 release (April 2022) label Apr 9, 2022
@jtcohen6 jtcohen6 self-requested a review April 11, 2022 16:53
@runleonarun
Copy link
Collaborator Author

runleonarun commented Apr 12, 2022

@gwenwindflower I'm not sure if you wanted to add any context, or does my example provide enough info?

Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Alphabetical order makes a lot more sense than, whatever arbitrary order these were in before :)

website/docs/reference/global-configs.md Outdated Show resolved Hide resolved
website/docs/reference/global-configs.md Show resolved Hide resolved
runleonarun and others added 3 commits April 12, 2022 12:50
* adding the select cache resource 1st draft

* add warning

* add version

* Update website/docs/reference/global-configs.md

* adding exmple

Co-authored-by: runleonarun <leona@dbtlabs.com>
Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes, otherwise it's mostly there!

website/docs/reference/global-configs.md Outdated Show resolved Hide resolved
website/docs/reference/global-configs.md Outdated Show resolved Hide resolved
website/docs/reference/global-configs.md Outdated Show resolved Hide resolved
website/docs/reference/global-configs.md Show resolved Hide resolved
Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more comments re: the caching flag, which is indeed tricky to explain/understand — but could have a big big impact for the powerusers who try it out

website/docs/reference/global-configs.md Outdated Show resolved Hide resolved
website/docs/reference/global-configs.md Outdated Show resolved Hide resolved
@runleonarun runleonarun requested a review from jtcohen6 April 14, 2022 18:29
@runleonarun
Copy link
Collaborator Author

runleonarun commented Apr 14, 2022

I got a verbal OK to merge from Jeremy, so merging now!

@runleonarun runleonarun merged commit bd5f272 into current Apr 14, 2022
@runleonarun runleonarun deleted the v1.1global_configs branch April 14, 2022 18:42
mirnawong1 added a commit that referenced this pull request Jan 23, 2024
[Preview](https://docs-getdbt-com-git-dbeatty-print-no-print-dbt-labs.vercel.app/reference/global-configs/print-output#suppress-print-messages-in-stdout)

resolves #4776

## What are you changing in this pull request and why?

I checked from v1.7 back to v1.1, and I couldn't get either of these to
work in any version:

Up to 1.5:
```yaml
config:
  no_print: true
```

1.5 and after:
```yaml
config:
  print: false
```

However, the `DBT_NO_PRINT` / `DBT_PRINT` environment variables and
`--no-print` and `--print` CLI flags _do_ work.

So I think the code example for `profiles.yml` was just accidentally
introduced in the following PRs, and we should remove it because it's
not actually an option for any versions.
- #1319
- #3134

For additional context, see:
- [Upgrading to
v1.1](https://docs.getdbt.com/docs/dbt-versions/core-upgrade/upgrading-to-v1.1#advanced-and-experimental-functionality)
- [Upgrading to
v1.5](https://docs.getdbt.com/docs/dbt-versions/core-upgrade/upgrading-to-v1.5#behavior-changes)
- #1102
- dbt-labs/dbt-core#4701
- #3122
- #3332

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [x] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt-core v1.1 Docs impact for the v1.1 release (April 2022)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --quiet flag docs and print macro
2 participants