-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update global configs for v 1.1 #1319
Conversation
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@gwenwindflower I'm not sure if you wanted to add any context, or does my example provide enough info? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Alphabetical order makes a lot more sense than, whatever arbitrary order these were in before :)
* adding the select cache resource 1st draft * add warning * add version * Update website/docs/reference/global-configs.md * adding exmple Co-authored-by: runleonarun <leona@dbtlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes, otherwise it's mostly there!
Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two more comments re: the caching flag, which is indeed tricky to explain/understand — but could have a big big impact for the powerusers who try it out
Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
I got a verbal OK to merge from Jeremy, so merging now! |
[Preview](https://docs-getdbt-com-git-dbeatty-print-no-print-dbt-labs.vercel.app/reference/global-configs/print-output#suppress-print-messages-in-stdout) resolves #4776 ## What are you changing in this pull request and why? I checked from v1.7 back to v1.1, and I couldn't get either of these to work in any version: Up to 1.5: ```yaml config: no_print: true ``` 1.5 and after: ```yaml config: print: false ``` However, the `DBT_NO_PRINT` / `DBT_PRINT` environment variables and `--no-print` and `--print` CLI flags _do_ work. So I think the code example for `profiles.yml` was just accidentally introduced in the following PRs, and we should remove it because it's not actually an option for any versions. - #1319 - #3134 For additional context, see: - [Upgrading to v1.1](https://docs.getdbt.com/docs/dbt-versions/core-upgrade/upgrading-to-v1.1#advanced-and-experimental-functionality) - [Upgrading to v1.5](https://docs.getdbt.com/docs/dbt-versions/core-upgrade/upgrading-to-v1.5#behavior-changes) - #1102 - dbt-labs/dbt-core#4701 - #3122 - #3332 ## Checklist - [x] Review the [Content style guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md) so my content adheres to these guidelines. - [x] For [docs versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning), review how to [version a whole page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version) and [version a block of content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
closes #1102
Description & motivation
This PR:
Pre-release docs
Is this change related to an unreleased version of dbt?
current
Checklist
If you added new pages (delete if not applicable):
website/sidebars.js
If you removed existing pages (delete if not applicable):
website/sidebars.js
_redirects