Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We no longer support static sql for metrics in the manifest, so don't try to show an empty code block #435

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

marcodamore
Copy link
Contributor

Because we no longer support static sql for metrics in the manifest, we should not show an empty sql codeblock in dbt docs for metrics

Description

Checklist

…we should not show an empty sql codeblock in dbt docs for metrics
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@jtcohen6
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Jul 18, 2023
@cla-bot
Copy link

cla-bot bot commented Jul 18, 2023

The cla-bot has been summoned, and re-checked this pull request!

@dbt-labs dbt-labs deleted a comment from cla-bot bot Jul 18, 2023
@dbt-labs dbt-labs deleted a comment from cla-bot bot Jul 18, 2023
@dbt-labs dbt-labs deleted a comment from cla-bot bot Jul 18, 2023
@dbt-labs dbt-labs deleted a comment from cla-bot bot Jul 18, 2023
@jtcohen6 jtcohen6 merged commit 78cb73d into main Jul 18, 2023
9 checks passed
@jtcohen6 jtcohen6 deleted the marco_remove_sqlblock_for_metrics branch July 18, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants