-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Move to hatch for build tooling #12192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
emmyoop
wants to merge
16
commits into
main
Choose a base branch
from
er/hatch-it
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+478
−308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12192 +/- ##
==========================================
- Coverage 91.98% 91.97% -0.01%
==========================================
Files 203 205 +2
Lines 24965 24967 +2
==========================================
Hits 22964 22964
- Misses 2001 2003 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
reorganize more to match adapters setup script comment dont pip install fix test commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12151
Problem
dbt-core used setuptools as its build backend while dbt-adapters and dbt-common use hatch, creating inconsistency across the dbt ecosystem. This complicated build processes, required maintaining legacy build files, and created build isolation issues (#10465) where wheels and source distributions weren't built in separate environments.
Solution
Build System Migration
pyproject.tomlcore/dbt/__version__.pyas single source of truth for versioningLegacy Cleanup
MANIFEST.in(package contents now defined declaratively)setup.pyto minimal compatibility shim for backwards compatibilityhatch buildinstead ofpython -m buildCI/CD Updates
Developer Experience
hatch run setupBuild Isolation
Checklist