Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IntermediateSnapshotNode class #10326

Closed
Tracked by #10151
gshank opened this issue Jun 18, 2024 · 0 comments · Fixed by #10332
Closed
Tracked by #10151

Remove IntermediateSnapshotNode class #10326

gshank opened this issue Jun 18, 2024 · 0 comments · Fixed by #10332
Labels
snapshots Issues related to dbt's snapshot functionality

Comments

@gshank
Copy link
Contributor

gshank commented Jun 18, 2024 •
edited
Loading

Description

The IntermediateSnapshotNode class was originally implemented in order to defer validation until a later point. This is probably no longer necessary because we have moved Snapshot validation to a post-parsing step. In addition because of this extra "intermediate" class there's some extra kludging in the snapshot parser which should be fixed up.

Acceptance Criteria

No Intermediate SnapshotNode class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
snapshots Issues related to dbt's snapshot functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary IntermediateSnapshotNode and EmptySnapshotConfig dbt-labs/dbt-core
1 participant
@gshank