Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare_all_columns not working on Presto #89

Closed
1 of 5 tasks
evabilski opened this issue Nov 30, 2023 · 3 comments
Closed
1 of 5 tasks

compare_all_columns not working on Presto #89

evabilski opened this issue Nov 30, 2023 · 3 comments
Labels
bug Something isn't working Stale triage

Comments

@evabilski
Copy link

Describe the bug

Function compare_all_columns does not work on Presto.

Steps to reproduce

Create test in Presto environment:

{{ audit_helper.compare_all_columns(
    a_relation=ref('test__old'),
    b_relation=ref('test__new'),
    primary_key="col_a"
)}}

Models to test (same query for each one):

select
 'a' AS col_a,
 'b' AS col_b

Screenshots and log output

line 29:7: mismatched input 'with'. Expecting: '(', 'SELECT', 'TABLE', 'VALUES'

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: Presto)

The output of dbt --version:
dbt-labs/audit_helper version: 0.9.0

Additional context

line 45-51, WITH main as((WITH double parenthesis followed by WITH does not seem to be allowed.
It works with one parenthesis.

Are you interested in contributing the fix?

I am going to suggest a PR

@evabilski evabilski added bug Something isn't working triage labels Nov 30, 2023
@remilepriol
Copy link

This would be very helpful for me as well. Meanwhile I am adding it as a project-wise adapter. Thank you for the fix @evabilski !

Copy link

github-actions bot commented Sep 2, 2024

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 2, 2024
Copy link

github-actions bot commented Sep 9, 2024

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants