Skip to content

Commit 2ac8a79

Browse files
committed
Fix clippy warnings
1 parent d48d1e1 commit 2ac8a79

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

src/adc.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ use crate::error::MockError;
6060
/// ADC transaction type
6161
///
6262
/// Models an ADC read
63-
#[derive(Clone, Debug, PartialEq)]
63+
#[derive(Clone, Debug, PartialEq, Eq)]
6464
pub struct Transaction<T> {
6565
expected_chan: u8,
6666
response: T,
@@ -94,7 +94,7 @@ macro_rules! mock_channel {
9494
($ADC:ident, $($pin:ident => $chan:expr),+ $(,)*) => {
9595
$(
9696
/// Mock ADC channel implementation
97-
#[derive(Clone, Debug, PartialEq)]
97+
#[derive(Clone, Debug, PartialEq, Eq)]
9898
pub struct $pin;
9999

100100
impl Channel<$ADC> for $pin {

src/error.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use std::{error::Error as StdError, fmt, io};
22

33
/// Errors that may occur during mocking.
4-
#[derive(PartialEq, Clone, Debug)]
4+
#[derive(PartialEq, Eq, Clone, Debug)]
55
pub enum MockError {
66
/// An I/O-Error occurred
77
Io(io::ErrorKind),

src/i2c.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ use crate::common::Generic;
7777
use crate::error::MockError;
7878

7979
/// I2C Transaction modes
80-
#[derive(Clone, Debug, PartialEq)]
80+
#[derive(Clone, Debug, PartialEq, Eq)]
8181
pub enum Mode {
8282
/// Write transaction
8383
Write,
@@ -90,7 +90,7 @@ pub enum Mode {
9090
/// I2C Transaction type
9191
///
9292
/// Models an I2C read or write
93-
#[derive(Clone, Debug, PartialEq)]
93+
#[derive(Clone, Debug, PartialEq, Eq)]
9494
pub struct Transaction {
9595
expected_mode: Mode,
9696
expected_addr: u8,

src/pin.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ use embedded_hal::PwmPin;
4949
pub type PwmDuty = u16;
5050

5151
/// MockPin transaction
52-
#[derive(PartialEq, Clone, Debug)]
52+
#[derive(PartialEq, Eq, Clone, Debug)]
5353
pub struct Transaction {
5454
/// Kind is the transaction kind (and data) expected
5555
kind: TransactionKind,
@@ -59,7 +59,7 @@ pub struct Transaction {
5959
err: Option<MockError>,
6060
}
6161

62-
#[derive(PartialEq, Clone, Debug)]
62+
#[derive(PartialEq, Eq, Copy, Clone, Debug)]
6363
/// Digital pin value enumeration
6464
pub enum State {
6565
/// Digital low state
@@ -126,7 +126,7 @@ impl Transaction {
126126
}
127127

128128
/// MockPin transaction kind.
129-
#[derive(PartialEq, Clone, Debug)]
129+
#[derive(PartialEq, Eq, Clone, Debug)]
130130
pub enum TransactionKind {
131131
/// Set the pin state
132132
Set(State),
@@ -212,7 +212,7 @@ impl InputPin for Mock {
212212

213213
let Transaction { kind, err } = s.next().expect("no expectation for pin::is_high call");
214214

215-
assert_eq!(kind.is_get(), true, "expected pin::get");
215+
assert!(kind.is_get(), "expected pin::get");
216216

217217
if let Some(e) = err {
218218
Err(e)
@@ -229,7 +229,7 @@ impl InputPin for Mock {
229229

230230
let Transaction { kind, err } = s.next().expect("no expectation for pin::is_low call");
231231

232-
assert_eq!(kind.is_get(), true, "expected pin::get");
232+
assert!(kind.is_get(), "expected pin::get");
233233

234234
if let Some(e) = err {
235235
Err(e)

src/spi.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ use crate::common::Generic;
5050
use crate::error::MockError;
5151

5252
/// SPI Transaction mode
53-
#[derive(Clone, Debug, PartialEq)]
53+
#[derive(Clone, Debug, PartialEq, Eq)]
5454
pub enum Mode {
5555
/// Write transaction
5656
Write,
@@ -65,7 +65,7 @@ pub enum Mode {
6565
/// SPI transaction type
6666
///
6767
/// Models an SPI write or transfer (with response)
68-
#[derive(Clone, Debug, PartialEq)]
68+
#[derive(Clone, Debug, PartialEq, Eq)]
6969
pub struct Transaction {
7070
expected_mode: Mode,
7171
expected_data: Vec<u8>,

0 commit comments

Comments
 (0)