Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added \echo & \qecho for Issue #1335 #1371

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Added \echo & \qecho for Issue #1335 #1371

merged 4 commits into from
Oct 6, 2023

Conversation

ERYoung11
Copy link
Contributor

Description

I added a simple \echo & \qecho command. \echo always prints to STDOUT per the documentation. \qecho prints to the current query output stream per the documentation

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2022

Codecov Report

Patch coverage: 51.91% and project coverage change: -4.62 ⚠️

Comparison is base (6884c29) 84.15% compared to head (01e29d5) 79.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1371      +/-   ##
==========================================
- Coverage   84.15%   79.53%   -4.62%     
==========================================
  Files          21       25       +4     
  Lines        2720     2986     +266     
==========================================
+ Hits         2289     2375      +86     
- Misses        431      611     +180     
Impacted Files Coverage Δ
pgcli/completion_refresher.py 91.76% <ø> (+1.17%) ⬆️
pgcli/magic.py 0.00% <0.00%> (ø)
pgcli/packages/parseutils/tables.py 97.67% <ø> (ø)
pgcli/packages/sqlcompletion.py 97.67% <ø> (ø)
pgcli/pgcompleter.py 96.95% <ø> (ø)
pgcli/pgstyle.py 64.00% <ø> (ø)
pgcli/pgtoolbar.py 31.57% <0.00%> (+0.15%) ⬆️
pgcli/pyev.py 15.38% <15.38%> (ø)
pgcli/explain_output_formatter.py 46.15% <46.15%> (ø)
pgcli/key_bindings.py 52.94% <66.66%> (-0.19%) ⬇️
... and 8 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ERYoung11
Copy link
Contributor Author

@j-bennet @amjith Any issues with this PR that I can address? (besides that changelog.rst now has a conflict)

Copy link
Contributor

@j-bennet j-bennet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ERYoung11
Copy link
Contributor Author

@j-bennet @amjith This PR is ready. Sorry for the delay!

@j-bennet
Copy link
Contributor

@ERYoung11 The PR is fine, but why not add the command to pgspecial?

@ERYoung11
Copy link
Contributor Author

ERYoung11 commented May 22, 2023

@j-bennet Great point! I'll rework it and resubmit.

@j-bennet j-bennet merged commit 43360b5 into dbcli:main Oct 6, 2023
@j-bennet
Copy link
Contributor

j-bennet commented Oct 6, 2023

So, pgspecial didn't happen :), but I merged the PR. It's a nice feature. Thank you @ERYoung11 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants