From 01a2c5ec211bbb3cb25582c39086a984c63c2126 Mon Sep 17 00:00:00 2001 From: Ying Wang Date: Tue, 26 Oct 2021 22:14:20 -0400 Subject: [PATCH] =?UTF-8?q?=F0=9F=A4=96=20Merge=20PR=20#56780=20chore:=20f?= =?UTF-8?q?ix=20typos=20in=20admin.md=20by=20@wingclover?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- docs/admin.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/admin.md b/docs/admin.md index dd6f8dcd7d7e80..3883d42a93259f 100644 --- a/docs/admin.md +++ b/docs/admin.md @@ -3,7 +3,7 @@ Welcome! This is a resource for the person who is on call for Definitely Typed. The TypeScript team always has someone assigned to Definitely Typed duty, where they do a week on-call. You can see the [schedule here](http://aka.ms/DTRotation). -When on-call, your goal is to try keep on top of the many open PRs for Definitely Typed; they are categorized into +When on-call, your goal is to try to keep on top of the many open PRs for Definitely Typed; they are categorized into different sections inside the [Projects board](https://github.com/DefinitelyTyped/DefinitelyTyped/projects/5) on this repo. You should scan from left to right through the boards, and ideally try to start at the oldest PR in a section and work @@ -51,7 +51,7 @@ You can control the life-cycle of PRs via "blessings", which are implicit operat * If a PR requires a *maintainer action*, you can move it to the `Waiting for Author to Merge` column to "merge-bless" it: make the bot offer the author to self-merge. This is particularly useful in cases where a PR author is unsure about something, and is trying to solicit review from owners or library authors: it makes it possible to defer the decision when to merge to the author, instead of starting an "are you ready" discussion. -You can use either of these blessings in other cases too, the above are just the common use cases. A review-blessing is only good to satisfy a maintainer review requirment (so other reviews will be needed), and a merge-blessing will usually make a PR self-mergable, but it will still wait until a PR is unconflicted and the CI is green. +You can use either of these blessings in other cases too, the above are just the common use cases. A review-blessing is only good to satisfy a maintainer review requirement (so other reviews will be needed), and a merge-blessing will usually make a PR self-mergeable, but it will still wait until a PR is unconflicted and the CI is green. Like a review, both kinds of blessings will be dismissed if the PR is updated. You can also undo a blessing by moving a PR to any other column.