Skip to content

Conversation

@nmerget
Copy link
Collaborator

@nmerget nmerget commented May 8, 2023

Fix issues for styling and css selectors

  1. alert
  2. link

@nmerget nmerget requested review from annsch, dkolba and mfranzke as code owners May 8, 2023 13:17
@github-actions github-actions bot added 🧱components Changes inside components folder 📺showcases Changes to 1-n showcases labels May 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-alert-link-snapshots

@nmerget nmerget enabled auto-merge (squash) May 8, 2023 13:37
@mfranzke mfranzke removed request for annsch and dkolba May 9, 2023 07:39
@nmerget nmerget changed the title fix: alert and link issue for snapshots fix: styling issues for alert, link, input May 10, 2023
@nmerget nmerget changed the title fix: styling issues for alert, link, input fix: styling issues for alert, link May 11, 2023
mfranzke
mfranzke previously approved these changes May 15, 2023
Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>
nmerget and others added 4 commits May 15, 2023 07:50
Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>
Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>
…shots

# Conflicts:
#	__snapshots__/button/showcase-button.spec.ts-snapshots/DBButton-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png
#	__snapshots__/button/showcase-button.spec.ts-snapshots/DBButton-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-firefox-linux.png
#	__snapshots__/button/showcase-button.spec.ts-snapshots/DBButton-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-mobile-chrome-linux.png
#	__snapshots__/button/showcase-button.spec.ts-snapshots/DBButton-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-mobile-safari-linux.png
#	__snapshots__/button/showcase-button.spec.ts-snapshots/DBButton-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-webkit-linux.png
#	__snapshots__/infotext/showcase-infotext.spec.ts-snapshots/DBInfotext-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png
#	__snapshots__/infotext/showcase-infotext.spec.ts-snapshots/DBInfotext-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-firefox-linux.png
#	__snapshots__/infotext/showcase-infotext.spec.ts-snapshots/DBInfotext-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-mobile-chrome-linux.png
#	__snapshots__/infotext/showcase-infotext.spec.ts-snapshots/DBInfotext-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-mobile-safari-linux.png
#	__snapshots__/infotext/showcase-infotext.spec.ts-snapshots/DBInfotext-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-webkit-linux.png
#	__snapshots__/input/showcase-input.spec.ts-snapshots/DBInput-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png
#	__snapshots__/input/showcase-input.spec.ts-snapshots/DBInput-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-firefox-linux.png
#	__snapshots__/input/showcase-input.spec.ts-snapshots/DBInput-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-mobile-chrome-linux.png
#	__snapshots__/input/showcase-input.spec.ts-snapshots/DBInput-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-mobile-safari-linux.png
#	__snapshots__/input/showcase-input.spec.ts-snapshots/DBInput-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-webkit-linux.png
#	__snapshots__/link/showcase-link.spec.ts-snapshots/DBLink-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png
#	__snapshots__/link/showcase-link.spec.ts-snapshots/DBLink-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-firefox-linux.png
#	__snapshots__/link/showcase-link.spec.ts-snapshots/DBLink-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-mobile-chrome-linux.png
#	__snapshots__/link/showcase-link.spec.ts-snapshots/DBLink-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-mobile-safari-linux.png
#	__snapshots__/link/showcase-link.spec.ts-snapshots/DBLink-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-webkit-linux.png
#	__snapshots__/section/showcase-section.spec.ts-snapshots/DBSection-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png
#	__snapshots__/section/showcase-section.spec.ts-snapshots/DBSection-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-firefox-linux.png
#	__snapshots__/section/showcase-section.spec.ts-snapshots/DBSection-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-mobile-chrome-linux.png
#	__snapshots__/section/showcase-section.spec.ts-snapshots/DBSection-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-mobile-safari-linux.png
#	__snapshots__/section/showcase-section.spec.ts-snapshots/DBSection-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-webkit-linux.png
@nmerget nmerget requested a review from mfranzke May 15, 2023 06:39
@nmerget nmerget merged commit 1bd9ba8 into main May 15, 2023
@nmerget nmerget deleted the fix-alert-link-snapshots branch May 15, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧱components Changes inside components folder 📺showcases Changes to 1-n showcases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants