Skip to content

Conversation

@sarahbrng
Copy link
Contributor

@sarahbrng sarahbrng commented Oct 15, 2025

Proposed changes

  • Create separate CSS files for each color (blue, brand, burgundy, etc.)
  • Move colors.css to colors/ subdirectory with adaptive theme
  • Add colors/index.css that imports all color variants
  • Update theme/index.css to import from colors/index.css
  • Each color file follows same structure as adaptive colors
  • Enables selective color imports for better modularity

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

fixes #4620

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/4620-figma-colors-variables-not-available-in-react

- Create separate CSS files for each color (blue, brand, burgundy, etc.)
- Move colors.css to colors/ subdirectory with adaptive theme
- Add colors/index.css that imports all color variants
- Update theme/index.css to import from colors/index.css
- Each color file follows same structure as adaptive colors
- Enables selective color imports for better modularity
@sarahbrng sarahbrng linked an issue Oct 15, 2025 that may be closed by this pull request
7 tasks
@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2025

🦋 Changeset detected

Latest commit: b4bab58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@db-ux/core-foundations Patch
@db-ux/core-components Patch
@db-ux/ngx-core-components Patch
@db-ux/react-core-components Patch
@db-ux/wc-core-components Patch
@db-ux/v-core-components Patch
@db-ux/core-stylelint Patch
@db-ux/core-migration Patch
@db-ux/agent-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nmerget
nmerget previously approved these changes Oct 16, 2025
@nmerget nmerget moved this from 🏗 In progress to 👀 Actively In Review in UX Engineering Team Backlog Oct 16, 2025
@sarahbrng sarahbrng enabled auto-merge (squash) October 16, 2025 09:03
@sarahbrng sarahbrng disabled auto-merge October 16, 2025 09:14
@sarahbrng sarahbrng enabled auto-merge (squash) October 16, 2025 09:18
@github-actions github-actions bot added the 📕documentation Improvements or additions to documentation label Oct 16, 2025
@nmerget nmerget self-requested a review October 16, 2025 09:19
@sarahbrng sarahbrng merged commit e8d58bd into main Oct 16, 2025
72 checks passed
@sarahbrng sarahbrng deleted the 4620-figma-colors-variables-not-available-in-react branch October 16, 2025 09:46
@github-project-automation github-project-automation bot moved this from 👀 Actively In Review to ✅ Done in UX Engineering Team Backlog Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📕documentation Improvements or additions to documentation 🏗foundations

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Figma colors variables not available in React

3 participants