fix(select): stencil tests #4904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 683861f.
mfranzke
added
🍄🆙improvement
|
Contributor
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-select-stencil-tests |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in UX Engineering Team Backlog
mfranzke
added a commit
that referenced
this pull request
Sep 6, 2025
* fix(tests): preventing test failure slipthrougs to main The [checks for a PR](https://github.com/db-ux-design-system/core-web/actions/runs/17416146706/job/49445191771?pr=4904) run through smoothly, but it's results would lead to a [fail on `main` branch](https://github.com/db-ux-design-system/core-web/actions/runs/17421313490/job/49460006681). We need to prevent this to happen. * Revert "fix(select): stencil tests (#4904)" This reverts commit ca0393e. * Revert "fix(select): Angular tests (#4903)" This reverts commit 683861f. * Update 02-e2e-showcases.yml * refactor: let's give this a try * Revert "refactor: let's give this a try" This reverts commit 8ff0b44. * Update select.lite.tsx * Update select.lite.tsx * Fix placeholder option value in select component * Modify ngAfterViewInit to handle floating variant * Update components.ts * Refactor ngAfterViewInit to simplify value assignment * Update components.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The StencilJS tests were incorrectly reporting the first item as selected, whereas it should be the second one.
Types of changes
Further comments