Skip to content

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Aug 6, 2025

Proposed changes

Resolves #4652

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke self-assigned this Aug 6, 2025
@mfranzke mfranzke requested a review from nmerget as a code owner August 6, 2025 15:31
@mfranzke mfranzke added the 📕documentation Improvements or additions to documentation label Aug 6, 2025
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Aug 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

@mfranzke mfranzke moved this to 👀 In review in UX Engineering Team Backlog Aug 6, 2025
@mfranzke mfranzke removed their assignment Aug 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This refactor consolidates font-related CSS custom properties by replacing separate font-size and line-height declarations with a single font shorthand property. The changes eliminate leftovers from release 2.x that used individual font properties.

  • Replaces separate font-size and line-height properties with font shorthand across multiple files
  • Updates code examples and documentation to reflect the new consolidated approach
  • Simplifies CSS declarations by reducing two properties to one

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
showcases/patternhub/styles/decision-tree.scss Updates h2 styles to use consolidated font property
showcases/patternhub/pages/foundations/font-sizes/overview.tsx Updates code examples and inline styles to use font shorthand
packages/foundations/docs/FontsSizes.md Updates documentation example to show font shorthand usage

michaelmkraus and others added 2 commits August 12, 2025 14:58
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
michaelmkraus
michaelmkraus previously approved these changes Aug 12, 2025
michaelmkraus
michaelmkraus previously approved these changes Aug 12, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke mfranzke merged commit a998dc8 into main Aug 12, 2025
54 checks passed
@mfranzke mfranzke deleted the 4652-outdated-documentation-about-overwriting-default-mappings-for-headlines branch August 12, 2025 18:24
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in UX Engineering Team Backlog Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📕documentation Improvements or additions to documentation 🍄🆙improvement New feature or request postReview

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Outdated documentation about overwriting default mappings for headlines

3 participants