refactor(input:read-only): aligned technical implementation to Figma specification
#4688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfranzke
added
🐛bug
6 tasks
Contributor
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This reverts commit ac86667.
mfranzke
changed the title
mfranzke
changed the title
mfranzke
changed the title
mfranzke
changed the title
input:read-only): aligned technical implementation to Figma specification
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the read-only input component implementation to align with Figma design specifications. The main changes focus on removing default values for read-only inputs and updating the background color styling.
- Updated background color for read-only inputs from opaque to transparent
- Removed hardcoded values from read-only input showcases
- Updated accessibility snapshots to reflect the removal of default values
Reviewed Changes
Copilot reviewed 8 out of 13 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| showcases/shared/input.json | Removed hardcoded value props from read-only input showcase examples |
| packages/components/src/styles/internal/_form-components.scss | Changed read-only input background from opaque to transparent styling |
| snapshots/input/showcase//should-have-same-aria-snapshot/.yaml | Updated accessibility snapshots to reflect removal of textbox values |
michaelmkraus
previously approved these changes
Aug 12, 2025
…g-von-figma-design-ab
…g-von-figma-design-ab
…g-von-figma-design-ab
michaelmkraus
approved these changes
Aug 12, 2025
mfranzke
deleted the
4334-read-only-feld-weicht-in-der-entwicklung-von-figma-design-ab
branch
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in UX Engineering Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves #4334
co-created with @maximilianklemm
Types of changes
Further comments