-
Notifications
You must be signed in to change notification settings - Fork 5
refactor: cards to match with dbux-3 #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
12fefa9
refactor: cards to match with dbux-3
nmerget 2b738d8
fix: issue with dependency
nmerget 1427d0e
chore: out of my dead cold hands …
mfranzke 8d87821
fix: we can define custom attributes by data-*
mfranzke 62169ea
chore(docs): optimized the code parts
mfranzke 868fc1c
Restore cards.hbs
mfranzke 8ec5415
refactor: let's leave the components contents for the moment
mfranzke a846093
fix: change _init.global.scss for a tags
nmerget 300d30c
Merge remote-tracking branch 'origin/refactor-guidelines-3-card' into…
nmerget 089c817
fix: removed sass:list from _color-variants.scss
nmerget ba076e7
Merge branch 'dbux-3' into refactor-guidelines-3-card
nmerget 68c3294
refactor: the full width is actually a variant currently
mfranzke f27e403
chore: these variables need to get named a little bit more exclusive
mfranzke facf42a
Update _init.global.scss
mfranzke 95f2f0a
Merge branch 'refactor-guidelines-3-card' of https://github.com/db-ui…
mfranzke 4d15af9
chore: prettier
mfranzke ee2d633
chore: even variant is an optional attribute
mfranzke 6e51535
refactor: an interactive element needs a link as well
mfranzke e226415
chore: this file has been moved to DB UI Base
mfranzke 2f27240
Merge branch 'dbux-3' into refactor-guidelines-3-card
mfranzke 9bc9467
fix: corrected that path
mfranzke eb15580
Merge branch 'dbux-3' into refactor-guidelines-3-card
mfranzke 35518f2
chore: heavily simplifying these examples
mfranzke b8e0c42
test: let's deactivate this component for the moment
mfranzke 44e7591
Merge branch 'dbux-3' into refactor-guidelines-3-card
mfranzke 50ef795
refactor: we need to extract the classes to an external file
mfranzke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
{{#unless list }} | ||
<div class="cmp-card"{{#if variant}} data-variant="{{ variant }}"{{/if }}> | ||
{{else}} | ||
<!-- [html-validate-disable-next element-permitted-content, element-permitted-parent -- we're only providing a partial here] --> | ||
<li class="cmp-card"{{#if variant}} data-variant="{{ variant }}"{{/if }}> | ||
{{/unless}} | ||
{{#if hyperlink }}<a href="#">{{/if }} | ||
{{#if figure }}<figure> | ||
{{#if_eq variant "banner" }} | ||
<svg xmlns="http://www.w3.org/2000/svg" width="64" height="64" aria-hidden="true"> | ||
<use href="../../icons/illustrative/{{ icon }}.svg#icon"></use> | ||
</svg> | ||
{{else}} | ||
{{> elements-image src="../../icons/functional/images/navigation/db_ic_list_20.svg" alt="" role="presentation" }} | ||
{{/if_eq }} | ||
<figcaption>{{/if }} | ||
{{#if headline}} | ||
<!-- [html-validate-disable-next heading-level] --> | ||
<h3 class="elm-headline">{{ headline }}</h3> | ||
{{/if }} | ||
{{#if text }}<p>{{{ text }}}</p>{{/if }} | ||
{{#if figure }}</figcaption> | ||
</figure>{{/if }} | ||
{{#if hyperlink }}</a>{{/if }} | ||
{{#unless list }} | ||
</div> | ||
{{else}} | ||
</li> | ||
{{/unless }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
<p>outer container db-bg-neutral-2</p> | ||
<div class="cmp-card db-bg-neutral-2"> | ||
<ul class="cmp-cards"> | ||
<li class="cmp-card"> | ||
<strong>db-bg-neutral-2</strong> | ||
<br> | ||
<a href="#">Test</a> | ||
</li> | ||
<li class="cmp-card"> | ||
<strong>db-bg-neutral-2</strong> | ||
<br> | ||
<a href="#">Test2</a> | ||
</li> | ||
<li class="cmp-card"> | ||
<strong>db-bg-neutral-2</strong> | ||
<br> | ||
<a href="#">Test3</a> | ||
</li> | ||
</ul> | ||
</div> | ||
|
||
<p>card with nested cards db-bg-information</p> | ||
<div class="cmp-card"> | ||
<ul class="cmp-cards"> | ||
<li class="cmp-card db-bg-information"> | ||
<strong>db-bg-information</strong> | ||
<br> | ||
<a href="#">Test</a> | ||
</li> | ||
<li class="cmp-card db-bg-information"> | ||
<strong>db-bg-information</strong> | ||
<br> | ||
<a href="#">Test2</a> | ||
</li> | ||
<li class="cmp-card db-bg-information"> | ||
<strong>db-bg-information</strong> | ||
<br> | ||
<a href="#">Test3</a> | ||
</li> | ||
</ul> | ||
</div> | ||
|
||
<p>cards with <code>data-color-variant=success-light</code></p> | ||
<ul class="cmp-cards"> | ||
<li class="cmp-card" data-color-variant="success-light"> | ||
<strong>db-bg-success-light</strong> | ||
<br> | ||
<a href="#">Test</a> | ||
</li> | ||
<li class="cmp-card" data-color-variant="success-light"> | ||
<strong>db-bg-success-light</strong> | ||
<br> | ||
<a href="#">Test2</a> | ||
</li> | ||
<li class="cmp-card" data-color-variant="success-light"> | ||
<strong>db-bg-success-light</strong> | ||
<br> | ||
<a href="#">Test3</a> | ||
</li> | ||
</ul> | ||
|
||
<p>cards with <code>data-color-variant=success-light</code> and <code>data-variant="ia"</code></p> | ||
|
||
<ul class="cmp-cards"> | ||
<li class="cmp-card" data-color-variant="success-light" data-variant="ia"> | ||
<strong>db-bg-success-light</strong> | ||
<br> | ||
<span>Test</span> | ||
</li> | ||
<li class="cmp-card" data-color-variant="success-light" data-variant="ia"> | ||
<strong>db-bg-success-light</strong> | ||
<br> | ||
<span>Test2</span> | ||
</li> | ||
<li class="cmp-card" data-color-variant="success-light" data-variant="ia"> | ||
<strong>db-bg-success-light</strong> | ||
<br> | ||
<span>Test3</span> | ||
</li> | ||
</ul> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
<ul class="cmp-cards"> | ||
{{#each cards }} | ||
{{> components-card variant=../variant }} | ||
{{> components-card variant=../variant list=true }} | ||
{{/each }} | ||
</ul> |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"cards": [ | ||
{ | ||
"headline": "Headline 01", | ||
"text": "Lorem ipsum dolores sint." | ||
}, | ||
{ | ||
"headline": "Headline 02", | ||
"text": "Lorem ipsum dolores sint." | ||
}, | ||
{ | ||
"headline": "Headline 03", | ||
"text": "Lorem ipsum dolores sint." | ||
}, | ||
{ | ||
"headline": "Headline 04", | ||
"text": "Lorem ipsum dolores sint." | ||
} | ||
] | ||
} |
25 changes: 25 additions & 0 deletions
25
source/_patterns/02-components/cards/cards~interactive.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
{ | ||
"variant": "ia", | ||
"cards": [ | ||
{ | ||
"headline": "Interactive 01", | ||
"text": "Lorem ipsum dolores sint.", | ||
"hyperlink": true | ||
}, | ||
{ | ||
"headline": "Interactive 02", | ||
"text": "Lorem ipsum dolores sint.", | ||
"hyperlink": true | ||
}, | ||
{ | ||
"headline": "Interactive 03", | ||
"text": "Lorem ipsum dolores sint.", | ||
"hyperlink": true | ||
}, | ||
{ | ||
"headline": "Interactive 04", | ||
"text": "Lorem ipsum dolores sint.", | ||
"hyperlink": true | ||
} | ||
] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"headline": "Test", | ||
"text": "Test 123", | ||
"variant": "width-full" | ||
} |
1 change: 0 additions & 1 deletion
1
source/_patterns/02-components/cards/enterprise/_cards.variables.scss
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1 @@ | ||
@import "cards.variables"; | ||
@import "../card"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
@import "cards.variables"; | ||
@import "../cards"; | ||
@import "../card"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.