Generate foreign key constraint on CREATE TABLE; Add feature test

Author: kremio

index.js

@@ -56,20 +56,21 @@ var Sqlite3Driver = Base.extend({
     callback(null);
   },
 
-  createColumnDef: function(name, spec, options) {
-    name = '"' + name + '"';
+  createColumnDef: function(name, spec, options, tableName) {
+    var quotedName = '"' + name + '"';
     var dType       = this.mapDataType(spec.type);
     var len        = spec.length ? util.format('(%s)', spec.length) : '';
-    var constraint = this.createColumnConstraint(spec, options);
+    var constraint = this.createColumnConstraint(spec, options, tableName, name);
 
     if(spec.type === type.INTEGER)
       len = '';
 
     return { foreignKey: null,
-                 constraints: [name, dType, len, constraint].join(' ') };
+                 constraints: [quotedName, dType, len, constraint].join(' ') };
   },
 
-  createColumnConstraint: function(spec, options) {
+  createColumnConstraint: function(spec, options, tableName, columnName) {
+    var cb;
     var constraint = [];
     if (spec.primaryKey && options.emitPrimaryKey) {
       constraint.push('PRIMARY KEY');
@@ -95,6 +96,22 @@ var Sqlite3Driver = Base.extend({
         constraint.push(spec.defaultValue);
     }
 
+    if (spec.foreignKey) {
+      constraint.push(`REFERENCES ${spec.foreignKey.table}(${spec.foreignKey.mapping})`)
+      if( spec.foreignKey.rules ){
+        Object.keys(spec.foreignKey.rules)
+          .forEach( (rule) => {
+            switch(rule){
+              case 'onDelete': constraint.push(`ON DELETE ${spec.foreignKey.rules[rule]}`)
+              break
+              case 'onUpdate': constraint.push(`ON UPDATE ${spec.foreignKey.rules[rule]}`)
+              break
+              default: throw new Error('Unsupported foreign key action trigger: ' + rule )
+            }
+          })
+      }
+    }
+
     return constraint.join(' ');
   },
 

test/foreign_key_batch.js

@@ -1,6 +1,7 @@
 const dbmeta = require('db-meta')
 const dataType = require('db-migrate-shared').dataType
 const fs = require('fs')
+const assert = require('assert')
 
 module.exports = (driver, config, internals) => ({
   'columnForeignKeySpec': {
@@ -20,7 +21,7 @@ module.exports = (driver, config, internals) => ({
               primaryKey: true,
               autoIncrement: true
             },
-            event_id: {
+            event_type_id: {
               type: dataType.INTEGER,
               notNull: true,
               foreignKey: {
@@ -51,11 +52,25 @@ module.exports = (driver, config, internals) => ({
           if (err) {
             return this.callback(err);
           }
-          meta.getColumns('event', this.callback);
+          meta.getTables( (err, tables) => {
+            if (err) {
+              return this.callback(err)
+            }
+            this.callback( undefined, tables.find( (table) => table.getName() == "event" ) )
+          })
         }.bind(this));
       },
-      'that has foreign key column with the expected reference': function (err, columns) {
-        console.log(err, columns)
+      'that has foreign key column with the expected reference': function (err, table) {
+//        console.log(err, table)
+        const foreignKeyDefinition = table.meta
+          .sql
+          .match(/"event_type_id"[^,]+/)[0]
+          .replace(/\s{2,}/g,'')
+        
+        assert.equal(
+          foreignKeyDefinition,
+          '"event_type_id" INTEGERNOT NULL REFERENCES event_type(id) ON DELETE CASCADE'
+        )
         /*var column = findByName(columns, 'id');
         assert.equal(column.getDataType(), 'INTEGER');
         assert.equal(column.isPrimaryKey(), true);

test/sqlite3_test.js

@@ -24,9 +24,7 @@ internals.migrationTable = 'migrations';
 vows.describe('sqlite3').addBatch({
   'createTable': {
     topic: function () {
-      console.log("cc")
       driver.connect(config, internals, function (err, db) {
-        console.log("cc_cc")
         db.createTable('event', {
           id: { type: dataType.INTEGER, primaryKey: true, autoIncrement: true, notNull: true },
           str: { type: dataType.STRING, unique: true },
@@ -40,7 +38,6 @@ vows.describe('sqlite3').addBatch({
     },
 
     teardown: function (db) {
-      console.log('tt')
       db.close(function (err) {
         fs.unlink(config.filename, this.callback);
       }.bind(this));