Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tuple types as contract function input #166

Open
AlanNabiev opened this issue Oct 10, 2022 · 3 comments
Open

Support tuple types as contract function input #166

AlanNabiev opened this issue Oct 10, 2022 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@AlanNabiev
Copy link

Hi, i cant use FallthroughProvider with multicalls libraries, such as 'ethcall'. Because provider object has different fields with JsonRpcProvider from ethers.js
Are there any solutions to this problem?

@AlanNabiev
Copy link
Author

Hi, i cant use FallthroughProvider with multicalls libraries, such as 'ethcall'. Because provider object has different fields with JsonRpcProvider from ethers.js Are there any solutions to this problem?

I tried to write my version of the multicall library. However, now when I call aggregate method on a multicall contract, I get this error.
Снимок экрана 2022-10-10 в 07 12 14

@dawsbot
Copy link
Owner

dawsbot commented Oct 11, 2022

Hi @AlanNabiev, thank you for providing that screenshot. Can you provide example code in a pull-request you used to get that screenshotted error?

I'd love to do TDD and go fix the error you're asking about here, so if you can provide a broken jest test, that will greatly help getting this fixed in the codebase 🙌

@dawsbot
Copy link
Owner

dawsbot commented Mar 5, 2023

Hi @AlanNabiev, can you provide more info to reproduce?

I'd love to do TDD and go fix the error you're asking about here, so if you can provide a broken jest test, that will greatly help getting this fixed in the codebase 🙌

@dawsbot dawsbot changed the title FallthroughProvider multicall Support tuple types as contract function input Apr 24, 2023
@dawsbot dawsbot added bug Something isn't working enhancement New feature or request labels Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants