-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meson: Some minor fixes/enhancements #270
Conversation
…bled This commit fixes "ERROR: Tried to enter directory "src/tests/cptests/", which has already been visited." when both of unit_tests and fuzzer are enabled. Signed-off-by: Mobin "Hojjat" Aydinfar <mobin@mobintestserver.ir>
8347fbd
to
da90dff
Compare
I removed my request for review because maybe you want to close #263 first. I opened this PR for CI checks mainly (CI checks in forks is painful!). |
There's generally no need to run full CI until a PR is ready. You can test it locally until then. I would prefer you don't open PR until you believe it's ready (if it fails CI, it's fine to fix it then). No need to request review, I already get a notification that the PR is opened, the request for review is just another notification. Pushing changes to PR once it's opened is best avoided because I may have already started reviewing. Then I have to start again or look separately at the changes between the different revisions. So please try to keep that to a minimum - get everything ready, check it over carefully, and then do one push when it's ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok except for one thing (noted).
In future though, please keep formatting changes and functional changes in separate PRs.
I just reworded commit message of bugfix to include what error got fixed. I didn't change code. |
I know, it's fine. I think I misunderstood what you meant when you said you opened it for CI checks mainly. Anyway, it's fine to open multiple PRs, I will get to them when I have time. This one was easy to review so I did so. |
Signed-off-by: Mobin "Hojjat" Aydinfar <mobin@mobintestserver.ir>
I think it should be checked through build system not through compiler. Signed-off-by: Mobin "Hojjat" Aydinfar <mobin@mobintestserver.ir>
Signed-off-by: Mobin "Hojjat" Aydinfar <mobin@mobintestserver.ir>
da90dff
to
96045ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, feel free to merge
Hmm |
Seems I locked the branch accidentally, I unlocked it now. |
|
Hi. After #263 (I'm waiting for @davmac314 review) It's time to post some minor fixes/patches for meson.
first commit is bugfix and other are enhancements. Each commit has its title (and its description about utmp related commit) for more info.
Regards
Signed-off-by: Mobin "Hojjat" Aydinfar <mobin@mobintestserver.ir>