-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emojis are not removed #47
Comments
Thank you for the report. I'll try to fix this as soon as possible. |
I'm currently considering removing the current regex and use instead this library as it would allow to replace the emojis with text. That was the initial goal. What do you think? |
I think it would be better to remove them by default; and replace them with some custom setting or optional argument passed to the function when needed. Or the opposite way. |
Yeah, that is the current behavior. The problem with it is that you lose information in the process. Contemplate the next scenario:
In both cases, applying the current code you'd get Just something to think about... |
We could cover all cases:
|
The new emojis like 🤗, 🥂, 🤔, 🤘fail to be removed.
Check this gist https://gist.github.com/octohedron/3823d081eb1b92abe93b570875ec77f4
The text was updated successfully, but these errors were encountered: