This repository was archived by the owner on Aug 23, 2022. It is now read-only.
Fixed reset intent clearing bug #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabbi
force-pushed
the
fix-intent-clearing-bug
branch
from
0f31e62 to
d6b9cf6
Compare
|
Thanks! I think this is fine for now. Did you try it with your original use case? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out, that when
validateOn !== 'change'or when there is no validators, control component never clearedresetintent. This, in turn, means that whenupdateOn !== 'change'is set, control cannot be changed by user.I've fixed this by always clearing the intent.
Fixes #982.
Feel free to suggest test improvements, I'm not sure this is currently done in optimal way. Should we check that text input is cleared instead (and is changeable by user after that)?