Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings for examples are needed #74

Closed
DominiqueVial opened this issue Jul 8, 2020 · 18 comments
Closed

Settings for examples are needed #74

DominiqueVial opened this issue Jul 8, 2020 · 18 comments
Labels
core This is related to the core package documentation Improvements or additions to documentation question Question about how to achieve something react Issue is related to React resolved This issue is resolved

Comments

@DominiqueVial
Copy link

Without settings next to each example I am afraid Embla is unusable but in very sample use cases. For example as a user I want to use Embla with thumbnail navigation. There is an example for it but no settings associated.

So I think adding detailed settings will be a huge improvement in this great piece of code !

😀

@davidjerleke
Copy link
Owner

Hello @DominiqueVial,

Thank you for your request. CodeSandboxes for each example are on their way! The documentation pages are brand new so give me some time to update it with useful code links 😉.

Best,
David

@DominiqueVial
Copy link
Author

OK @davidcetinkaya

I give you the time!
I am currently polishing the next version of my artistic website, using another carousel but I keep an eye on Embla.

Best,

Dominique

@davidjerleke
Copy link
Owner

I will let you know when I have something @DominiqueVial 🙂.

Best,
David

@davidjerleke davidjerleke added question Question about how to achieve something documentation Improvements or additions to documentation labels Jul 8, 2020
@DarceyLloyd
Copy link

bump...

Nice examples, but only installation page has code template that is usable. Tried to view source on them but you got some build process going on for full page js render so that's out the window.... angular? react? vue? custom? Other than inspect element and script hunting in dev tools it's a no go... Look forward to docs / template pages with usable source available.

@davidjerleke
Copy link
Owner

davidjerleke commented Jul 10, 2020

Hello Darcey (@DarceyLloyd),

As discussed in this issue, examples are on their way. In the meantime, if you want to get started with some basic setups, take a look at these CodeSandboxes:

Currently, Embla Carousel supports vanilla JavaScript and React usages.

Keep an eye on this issue or hit the watch button if you want to be notified when the new code examples are published.

The documentation page is built with React.

Kindly
David

@DarceyLloyd
Copy link

Nice 1 Dave...

I've already got an implementation of the carousel running via vanilla JS ES6+ webpack babel project, I wanted to implement the carousel with the square thumbnail and tracking that, could have hooked into 2 embla carousels and told them to scroll to n but didn't have time to trial and error.

But yep, will keep an eye out for updates.

And thanks for the links.

Keep up the great work :)

Code on :)

@davidjerleke
Copy link
Owner

Hello again @DominiqueVial ,

Which variant of Embla are you using? Vanilla-JS or React?

Kindly,
David

@davidjerleke
Copy link
Owner

davidjerleke commented Jul 13, 2020

Hello again Darcey (@DarceyLloyd),

The vanilla thumbnail CodeSandbox is ready. Click on the Edit Code link on the examples page.

Let me know if it helps!

Best,
David

@DarceyLloyd
Copy link

DarceyLloyd commented Jul 13, 2020

Hi Dave,

RE: Vanilla or React
I'm using embla on woocommerce single item shop pages, so it's plain old vanilla js. I'm generating a json string of data via php for parsing via js which in turn generates the DOM structures for emblad to use, then I initialise embla.

RE: Example code
Excellent and looks good! As soon as I get a bit of time to revisit the woocommerce single item shop page I will give it a go.

Thanks

Darcey

@davidjerleke
Copy link
Owner

@DominiqueVial any updates on this?

Kindly,
David

@DominiqueVial
Copy link
Author

Hi Dave,

I don't use Embla for now. My plan is to use it on Kirby, with vanilla JavaScript.

;-)

@davidjerleke
Copy link
Owner

I see @DominiqueVial, thanks. When you’re ready, you can check out the vanilla thumbnail example as described here.

@davidjerleke davidjerleke added react Issue is related to React core This is related to the core package labels Jul 18, 2020
@davidjerleke
Copy link
Owner

The vanilla JavaScript examples are in place. React CodeSandboxes are next up.

@davidjerleke
Copy link
Owner

@DominiqueVial and @DarceyLloyd I'm closing this because I've added CodeSandbox links to every example on the documentation page. Enjoy!

@davidjerleke davidjerleke added the resolved This issue is resolved label Jul 29, 2020
@davidjerleke
Copy link
Owner

davidjerleke commented Jul 29, 2020

Hello Nick (@ndimatteo),

The React Autoplay CodeSandbox as we discussed some time ago in this issue is ready. Scroll down to the bottom of the page on the examples page here if you're interested.

Please note that the React package has moved into the core library as described in this issue.

Kindly,
David

@RoyiAvital
Copy link

RoyiAvital commented Dec 15, 2020

@davidjerleke, For me, as unexperienced Hugo user, the Vanilla JS doesn't make sense.
It loads a module which is available locally yet I can't understand how to get it.

Could you please generate examples using a single CSS file for the slider and the CDN link you mention?

Thank You.

@davidjerleke
Copy link
Owner

Thank you for your question @RoyiAvital.
No, sorry. I'm not planning to add CodeSandbox examples using CDN only.

@RoyiAvital
Copy link

Could you make the module file available for download?
As they are implied by CodeSandbox but are not seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This is related to the core package documentation Improvements or additions to documentation question Question about how to achieve something react Issue is related to React resolved This issue is resolved
Projects
None yet
Development

No branches or pull requests

4 participants