Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize handler precision mismatch #571

Closed
Tracked by #321
davidjerleke opened this issue Sep 19, 2023 Discussed in #569 · 0 comments · Fixed by #570
Closed
Tracked by #321

Resize handler precision mismatch #571

davidjerleke opened this issue Sep 19, 2023 Discussed in #569 · 0 comments · Fixed by #570
Labels
bug Something isn't working resolved This issue is resolved

Comments

@davidjerleke
Copy link
Owner

davidjerleke commented Sep 19, 2023

Discussed in #569.

Bug description

Originally posted by hamidrezahanafi September 18, 2023
The trigger to resize observer is coming from a height change in the slides but we only check the widths for an axis x slider. In this case width didn't change but upon checking the old width 163.890625 and new width 163.89060974121094 it seems that style width and observer width have different precision. 163.890625 is the actual rounded number of 163.89060974121094.
So library trigger a resize event without any width change which I think is library issue.

Suggested solution

@davidjerleke davidjerleke added the bug Something isn't working label Sep 19, 2023
@davidjerleke davidjerleke linked a pull request Sep 19, 2023 that will close this issue
@davidjerleke davidjerleke added the resolved This issue is resolved label Sep 19, 2023
@davidjerleke davidjerleke mentioned this issue Sep 19, 2023
37 tasks
@davidjerleke davidjerleke changed the title Fix resize handler precision mismatch Resize handler precision mismatch Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved This issue is resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant