Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 slide is not displayed #12

Closed
afilp opened this issue Jun 18, 2019 · 4 comments
Closed

1 slide is not displayed #12

afilp opened this issue Jun 18, 2019 · 4 comments
Labels
bug Something isn't working resolved This issue is resolved

Comments

@afilp
Copy link

afilp commented Jun 18, 2019

When I have 2 slides, the carousel works as expected.

If I have just 1 slide the slide does not show and it is with left: 100%.

I found that the reason is the option loop: true.

Since we are populating the slides dynamically, can the lib disable the loop if the slide is just one?

@davidjerleke
Copy link
Owner

davidjerleke commented Jun 18, 2019

Hello @afilp,
Thank you for reporting this 👍🏻.

Good catch 🙂! I think your suggestion makes sense. I’ll get to it as soon as I have access to my computer. Stay tuned.

@davidjerleke davidjerleke added the bug Something isn't working label Jun 18, 2019
@davidjerleke
Copy link
Owner

davidjerleke commented Jun 19, 2019

Hi @afilp,

Release v0.9.4 should be a solution to this problem 🎉. Please give it a shot and confirm if it's working or not.

⚠️ Please note that if you install the latest version it's a major version (v2.0.0) and it comes with breaking changes. See the release details if you're affected by this.

Thank you 👍!

@davidjerleke davidjerleke reopened this Jun 19, 2019
@davidjerleke davidjerleke added the awaiting response Issue is awaiting feedback label Jun 19, 2019
@davidjerleke
Copy link
Owner

davidjerleke commented Jun 26, 2019

@afilp,
Have you had a chance to confirm if the changes solved the issue?

Thank you in advance.

@davidjerleke
Copy link
Owner

davidjerleke commented Jul 1, 2019

I'm closing this issue due to inactivity. Feel free to reopen this issue if needed 👍.

Thanks!

@davidjerleke davidjerleke removed the awaiting response Issue is awaiting feedback label Jul 4, 2019
@davidjerleke davidjerleke added the resolved This issue is resolved label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved This issue is resolved
Projects
None yet
Development

No branches or pull requests

2 participants