Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning message for embla-carousel-react users #119

Closed
davidspiess opened this issue Nov 18, 2020 · 4 comments
Closed

Deprecation warning message for embla-carousel-react users #119

davidspiess opened this issue Nov 18, 2020 · 4 comments
Labels
documentation Improvements or additions to documentation react Issue is related to React

Comments

@davidspiess
Copy link

davidspiess commented Nov 18, 2020

I had absolutely no idea embla-carousel-react was moved into the embla-carousel package. NPM always told me i had the newest version, so i missed two major version updates.
Can you release a new minor embla-carousel-react version, which informs the users that the package is abandoned? (https://github.com/dylang/shortid package did this recently too). There are still more than 2000 downloads each week for the old package, so maybe there are some other people out there not knowing about this.

@davidjerleke
Copy link
Owner

davidjerleke commented Nov 18, 2020

Hello David (@davidspiess),

Thank you sharing this. Your suggestion makes a lot of sense! I've officially deprecated the package by following the guidelines in the NPM docs.

Would you mind verifying that you get the deprecation notice followed by the message in red, when you try to install the embla-carousel-react package 👇?

deprecation-notice

Note that you might need to clear your NPM cache in order for it to work properly. By the way, how did you notice that it was deprecated? Just curious how it came to your knowledge.

Thanks in advance,
David

@davidjerleke davidjerleke added documentation Improvements or additions to documentation react Issue is related to React labels Nov 18, 2020
@davidspiess
Copy link
Author

davidspiess commented Nov 18, 2020

Hi David!
Awesome! Now i get a warning in NPM!
image

By the way, how did you notice that it was deprecated?

It was a coincidence. I updated to React 17 and got a warning that embla-carousel-react requires a peer dependency of React 16. So i went to the repo to report that. 😋

@davidjerleke
Copy link
Owner

davidjerleke commented Nov 19, 2020

Thanks for confirming David (@davidspiess). Ah I see. In that case, you have some catching up to do 😅. Read more here:

Thank you for creating this issue.
Enjoy!

@davidspiess
Copy link
Author

Already upgraded, it was painless, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation react Issue is related to React
Projects
None yet
Development

No branches or pull requests

2 participants