Allow min and max to have same value #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidchin Any chance this can be added to the next release? We'd love to help if we can. |
|
Sure. And thank you for your work. Can you add a test case verifying that min/max can be the same? Also, can you add a prop so that your change is backward compatible? |
|
@davidchin We also have a requirement to set max and min value to same value. As I can tell it is planned that this feature is added to the component? (if yes, when?) thank you. |
|
@davidchin tests and prop added. Thanks much! |
|
Thanks @jhblacklock, your changes have been released as |
oyeanuj
added a commit
to oyeanuj/react-input-range
that referenced
this pull request
Mar 8, 2018
… into upgraded * 'master' of https://github.com/davidchin/react-input-range: (34 commits) Release v1.3.0 chore: Run test and generate changelog before tagging new version chore: Add `allowSameValues` to TypeScript definition docs: Add `allowSameValues` property to README feat: Allow min and max to have same value (davidchin#114) Release v1.2.2 chore: Add version prefix style: Fix comment indentation Update package.json (davidchin#111) Release v1.2.1 fix: Always set slider dragging back to false (davidchin#98) docs: Remove deprecated prop from example docs: Add description for new prop Release v1.2.0 fix: Add missing prop in definition file feat: Add track dragging functionality (davidchin#91) Release v1.1.5 fix: Typescript definition file style: Move setup block into describe block Release v1.1.4 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#55 and #92.
lastKeyMovedsets which slider gets rendered last.