From 9f4ee25cf7f37bdf4280e69cd7bb589cce0f468a Mon Sep 17 00:00:00 2001 From: Nimish Date: Fri, 15 Feb 2019 05:51:23 -0800 Subject: [PATCH] fix: remove the unused packages and convert minimist to yargs (#23467) Summary: `Minimist` package functionality can be done easily using `yargs` package. Also removed couple of unused dependencies. [General] [changed] - used `yarns` package instead of `minimist` package Pull Request resolved: https://github.com/facebook/react-native/pull/23467 Differential Revision: D14099638 Pulled By: cpojer fbshipit-source-id: 59de2086e4204e09c91fd2c99d209ca32c0ef82c --- jest/setup.js | 2 +- package.json | 5 ----- scripts/bump-oss-version.js | 11 +++++------ 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/jest/setup.js b/jest/setup.js index bc66b9161714df..9a5291a88f87e3 100644 --- a/jest/setup.js +++ b/jest/setup.js @@ -28,7 +28,7 @@ global.cancelAnimationFrame = function(id) { clearTimeout(id); }; -jest.mock('setupDevtools').mock('npmlog'); +jest.mock('setupDevtools'); // there's a __mock__ for it. jest.setMock('ErrorUtils', require('ErrorUtils')); diff --git a/package.json b/package.json index 95e35c9d33506a..e864671cf1b597 100644 --- a/package.json +++ b/package.json @@ -162,20 +162,15 @@ "@react-native-community/cli": "^1.1.0", "art": "^0.10.0", "base64-js": "^1.1.2", - "connect": "^3.6.5", "create-react-class": "^15.6.3", - "debug": "^2.2.0", "escape-string-regexp": "^1.0.5", "event-target-shim": "^1.0.5", "fbjs": "^1.0.0", "fbjs-scripts": "^1.0.0", "invariant": "^2.2.4", - "lodash": "^4.17.5", "metro-babel-register": "0.51.0", "metro-react-native-babel-transformer": "0.51.0", - "minimist": "^1.2.0", "mkdirp": "^0.5.1", - "npmlog": "^2.0.4", "nullthrows": "^1.1.0", "pretty-format": "24.0.0-alpha.6", "promise": "^7.1.1", diff --git a/scripts/bump-oss-version.js b/scripts/bump-oss-version.js index 9518de37388df1..8ee5d10c7acd04 100755 --- a/scripts/bump-oss-version.js +++ b/scripts/bump-oss-version.js @@ -17,13 +17,12 @@ */ const fs = require('fs'); const {cat, echo, exec, exit, sed} = require('shelljs'); +const yargs = require('yargs'); -const minimist = require('minimist'); - -let argv = minimist(process.argv.slice(2), { - alias: {remote: 'r'}, - default: {remote: 'origin'}, -}); +let argv = yargs.option('r', { + alias: 'remote', + default: 'origin', +}).argv; // - check we are in release branch, e.g. 0.33-stable let branch = exec('git symbolic-ref --short HEAD', {