Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken with Bootstrap5 #26

Open
MarksEliel opened this issue May 6, 2021 · 4 comments
Open

Broken with Bootstrap5 #26

MarksEliel opened this issue May 6, 2021 · 4 comments
Labels

Comments

@MarksEliel
Copy link

When do you intend to release an update compatible with bootstrap 5?

@glutamate
Copy link

glutamate commented Feb 21, 2022

I made this work with bootstrap 5 @MarksEliel @davicotico. The only problem I saw was the icon picker not displaying its pop up in the right place. To fix this, change this line:

var tip = ($.fn.bsVersion() === '3.x') ? el.tip() : $(el.getTipElement())

(https://github.com/davicotico/jQuery-Menu-Editor/blob/master/bootstrap-iconpicker/js/bootstrap-iconpicker.js#L497)

to:

                              var tip = ($.fn.bsVersion() === '3.x') ? el.tip() 
                                      : ($.fn.bsVersion() === '5.x') 
                                      ? $(bootstrap.Popover.getInstance($this).getTipElement())
                                      : $(el.getTipElement())

This was helpful: itsjavi/bootstrap-colorpicker#327 (comment)

Is anyone able to recreate the minified js file? It's not very important to me, so I will just serve the modified un-minified file for now

@glutamate
Copy link

you should also change the float-right class in TButtonGroup to float-end

@InsiteFX
Copy link

None of this is working in Bootstrap 5.3.2

Hope this gets fixed soon.

@davicotico
Copy link
Owner

Hi @InsiteFX , @glutamate , @MarksEliel
You can try Vanilla Javascript Menu Editor. I have worked on and will continue to work on Vanilla Javascript Menu Editor.
jQuery Menu Editor is not deprecated, but for now, I have no plans to update it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants