Bug fixes and better restrictions for protected tags (#11)

* Fix CSS issue where display: none was not enforced, causing gaps within the sidebar.

* Fixed inconsistency with variable not being boolean values.

* Fix widget support bug, where editing tag with icon would crash when children isn't available.
Fix protection tag should be hidden for Tags Page for secondary tags. Cloud function used for TagsPage
Fix child tag being shown on TagsPage if they should be hidden from view
Fix lastDiscussion for tag, showing protected tag
Added Protected view for DiscussionList, this can be hidden or displayed using the new settings options

* Fix issue where clicking on discussion will reload the page once, added hash to prevent refresh

Author: Yippy

extend.php

@@ -14,10 +14,12 @@
 use Datlechin\TagPasswords\Access\ScopeDiscussionVisibilityForAbility;
 use Datlechin\TagPasswords\Api\Controller\AuthController;
 use Datlechin\TagPasswords\Listener\AddTagAttributes;
+use Datlechin\TagPasswords\Listener\AddDiscussionAttributes;
 use Datlechin\TagPasswords\Listener\SavePasswordToDatabase;
 use Flarum\Discussion\Discussion;
 use Flarum\Extend;
 use Flarum\Tags\Api\Serializer\TagSerializer;
+use Flarum\Api\Serializer\DiscussionSerializer;
 use Flarum\Tags\Event\Saving;
 
 return [
@@ -36,6 +38,9 @@
     (new Extend\ApiSerializer(TagSerializer::class))
         ->attributes(AddTagAttributes::class),
 
+    (new Extend\ApiSerializer(DiscussionSerializer::class))
+        ->attributes(AddDiscussionAttributes::class),
+
     (new Extend\Routes('api'))
         ->post('/datlechin/tag-passwords/auth', 'datlechin-tag-passwords.auth', AuthController::class),
 
@@ -45,5 +50,9 @@
     (new Extend\Settings())
         ->default('flarum-tag-passwords.display_unlock_icon', true)
         ->default('flarum-tag-passwords.display_protected_tag_from_sidebar', true)
-        ->default('flarum-tag-passwords.display_protected_tag_from_tags_page', true),
+        ->default('flarum-tag-passwords.display_protected_tag_from_tags_page', true)
+        ->default('flarum-tag-passwords.display_protected_tag_from_discussion_list', false)
+        ->default('flarum-tag-passwords.display_discussion_avator', false)
+        ->serializeToForum('flarum-tag-passwords.displayProtectedTagForDiscussionList', 'flarum-tag-passwords.display_protected_tag_from_discussion_list', 'boolval', false)
+        ->serializeToForum('flarum-tag-passwords.displayDiscussionAvator', 'flarum-tag-passwords.display_discussion_avator', 'boolval', false)
 ];