Skip to content

fix: add cleanup on cancelling fetchSpec API #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2025
Merged

fix: add cleanup on cancelling fetchSpec API #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/src/modules/destinations/pages/CreateDestination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ const CreateDestination = forwardRef<
setLoadingVersions(true)
try {
const response = await destinationService.getDestinationVersions(
connector.toLowerCase() === CONNECTOR_TYPES.APACHE_ICEBERG
connector === CONNECTOR_TYPES.APACHE_ICEBERG
? DESTINATION_INTERNAL_TYPES.ICEBERG
: DESTINATION_INTERNAL_TYPES.S3,
)
Expand Down Expand Up @@ -305,7 +305,7 @@ const CreateDestination = forwardRef<
}

useEffect(() => {
handleFetchSpec()
return handleFetchSpec()
}, [
connector,
version,
Expand Down
2 changes: 1 addition & 1 deletion ui/src/modules/destinations/pages/DestinationEdit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ const DestinationEdit: React.FC<DestinationEditProps> = ({
}

useEffect(() => {
handleFetchSpec()
return handleFetchSpec()
}, [connector, selectedVersion, fromJobFlow, sourceConnector, sourceVersion])

const handleVersionChange = (value: string) => {
Expand Down
2 changes: 1 addition & 1 deletion ui/src/modules/sources/pages/CreateSource.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ const CreateSource = forwardRef<CreateSourceHandle, CreateSourceProps>(
}

useEffect(() => {
handleFetchSpec()
return handleFetchSpec()
}, [connector, selectedVersion, setupType])

useEffect(() => {
Expand Down
2 changes: 1 addition & 1 deletion ui/src/modules/sources/pages/SourceEdit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ const SourceEdit: React.FC<SourceEditProps> = ({
}

useEffect(() => {
handleFetchSpec()
return handleFetchSpec()
}, [connector, selectedVersion])

const resetVersionState = () => {
Expand Down