Add node.js 10 to CI matrices and update tests to account for changes in node.js 10 #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a local address may resolve to localhost depends on DNS configuration. i.e. systemd-resolved adds a 127.0.0.53 dns server in ubuntu 17.0.4+ that would resolve 127.100.100.1 to localhost.
Validate on expected Error instead of expected message to avoid ERR_AMBIGUOUS_ARGUMENT.
As of node 10, all 'readable' events are deferred to nextTick. See nodejs/node@1e0f3315c7 for more info.
Also run integration tests with node 8 instead of 6 in appveyor
|
I imagine finding the underlying issue for stream-based test was a tough one :) nodejs/node#17979 Great fixes! +1 |
|
Indeed it was! I ultimately found the notice about it in the release notes:
But it was definitely puzzling at first 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds node.js 10 to our test matrices.
Also makes a number of test changes:
127.100.100.1resolves by default in Ubuntu 17.04+ so using a reserved address seemed more reliable.stringfor validating expectation.readableevents tonextTick.