Fix handling of duplicate SRT conclusion handshakes on listener side#138
Open
346 wants to merge 2 commits into
Open
Fix handling of duplicate SRT conclusion handshakes on listener side#138346 wants to merge 2 commits into
346 wants to merge 2 commits into
Conversation
Store the accepted listener handshake response and resend it when a caller retransmits the conclusion handshake. This prevents callers from timing out when the original conclusion response is lost, while still avoiding duplicate SRT connections for repeated conclusion requests. Add test coverage to verify repeated conclusion handshakes receive a conclusion response.
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 56.54% 56.63% +0.08%
==========================================
Files 23 23
Lines 4237 4255 +18
==========================================
+ Hits 2396 2410 +14
- Misses 1519 1521 +2
- Partials 322 324 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes listener-side handling of duplicate SRT conclusion handshakes.
When a caller retransmits the conclusion handshake due to packet loss of the initial response, the listener currently ignores the duplicate request after the connection has already been accepted. As a result, the caller can time out even though the listener successfully accepted the connection.
With this change, the listener stores the accepted conclusion response and resends it upon receiving a duplicate conclusion handshake for an already accepted peer socket ID.
Changes