fix linter and test errors

Author: kosarko

src/app/item-page/clarin-files-section/clarin-files-section.component.spec.ts

@@ -23,7 +23,7 @@ describe('ClarinFilesSectionComponent', () => {
   let halService: HALEndpointService;
   // Set up the mock service's getMetadataBitstream method to return a simple stream
   const metadatabitstream = new MetadataBitstream();
-  metadatabitstream.id = 123;
+  metadatabitstream.id = '70ccc608-f6a5-4c96-ab2d-53bc56ae8ebe';
   metadatabitstream.name = 'test';
   metadatabitstream.description = 'test';
   metadatabitstream.fileSize = 1024;

src/app/item-page/simple/field-components/preview-section/file-description/file-description.component.spec.ts

@@ -12,11 +12,20 @@ import { RouterTestingModule } from '@angular/router/testing';
 import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
 import { HALEndpointService } from '../../../../../core/shared/hal-endpoint.service';
 import { FileSizePipe } from '../../../../../shared/utils/file-size-pipe';
+import {BitstreamDataService} from '../../../../../core/data/bitstream-data.service';
+import {AuthService} from '../../../../../core/auth/auth.service';
+import {AuthorizationDataService} from '../../../../../core/data/feature-authorization/authorization-data.service';
+import {FileService} from '../../../../../core/shared/file.service';
+import {AuthServiceStub} from '../../../../../shared/testing/auth-service.stub';
+import {FileServiceStub} from '../../../../../shared/testing/file-service.stub';
+import {AuthorizationDataServiceStub} from '../../../../../shared/testing/authorization-service.stub';
+import {Bitstream} from '../../../../../core/shared/bitstream.model';
 
 describe('FileDescriptionComponent', () => {
   let component: FileDescriptionComponent;
   let fixture: ComponentFixture<FileDescriptionComponent>;
   let halService: HALEndpointService;
+  let bitstreamDataService: BitstreamDataService;
 
   beforeEach(async () => {
     const configurationDataService = jasmine.createSpyObj('configurationDataService', {
@@ -32,6 +41,10 @@ describe('FileDescriptionComponent', () => {
       getRootHref: 'root url',
     });
 
+    bitstreamDataService = jasmine.createSpyObj('bitstreamDataService', {
+      findById: createSuccessfulRemoteDataObject$(new Bitstream()),
+    });
+
     await TestBed.configureTestingModule({
         imports: [TranslateModule.forRoot({
           loader: {
@@ -42,7 +55,11 @@ describe('FileDescriptionComponent', () => {
       declarations: [FileDescriptionComponent, FileSizePipe],
       providers: [
         { provide: ConfigurationDataService, useValue: configurationDataService },
-        { provide: HALEndpointService, useValue: halService }
+        { provide: HALEndpointService, useValue: halService },
+        { provide: AuthService, useClass: AuthServiceStub },
+        { provide: FileService, useClass: FileServiceStub },
+        { provide: AuthorizationDataService, useClass: AuthorizationDataServiceStub },
+        { provide: BitstreamDataService, useValue: bitstreamDataService },
       ]
     }).compileComponents();
   });
@@ -53,7 +70,7 @@ describe('FileDescriptionComponent', () => {
 
     // Mock the input value
     const fileInput = new MetadataBitstream();
-    fileInput.id = 123;
+    fileInput.id = '66efe81e-2950-483d-a065-bbdacd689f95';
     fileInput.name = 'testFile';
     fileInput.description = 'test description';
     fileInput.fileSize = 2048;

src/app/item-page/simple/field-components/preview-section/file-description/file-description.component.ts

@@ -4,17 +4,17 @@ import {HALEndpointService} from '../../../../../core/shared/hal-endpoint.servic
 import {Router} from '@angular/router';
 import {ConfigurationDataService} from '../../../../../core/data/configuration-data.service';
 import {getFirstCompletedRemoteData, getFirstSucceededRemoteData} from '../../../../../core/shared/operators';
-import {BitstreamDataService} from "../../../../../core/data/bitstream-data.service";
-import {Bitstream} from "../../../../../core/shared/bitstream.model";
-import {RemoteData} from "../../../../../core/data/remote-data";
-import {followLink} from "../../../../../shared/utils/follow-link-config.model";
-import {fromEvent, merge, Observable, of} from "rxjs";
-import {FileService} from "../../../../../core/shared/file.service";
-import {distinctUntilChanged, switchMap, take} from "rxjs/operators";
-import {FeatureID} from "../../../../../core/data/feature-authorization/feature-id";
-import {hasValue} from "../../../../../shared/empty.util";
-import {AuthorizationDataService} from "../../../../../core/data/feature-authorization/authorization-data.service";
-import {AuthService} from "../../../../../core/auth/auth.service";
+import {BitstreamDataService} from '../../../../../core/data/bitstream-data.service';
+import {Bitstream} from '../../../../../core/shared/bitstream.model';
+import {RemoteData} from '../../../../../core/data/remote-data';
+import {followLink} from '../../../../../shared/utils/follow-link-config.model';
+import {fromEvent, merge, Observable, of} from 'rxjs';
+import {FileService} from '../../../../../core/shared/file.service';
+import {distinctUntilChanged, switchMap, take} from 'rxjs/operators';
+import {FeatureID} from '../../../../../core/data/feature-authorization/feature-id';
+import {hasValue} from '../../../../../shared/empty.util';
+import {AuthorizationDataService} from '../../../../../core/data/feature-authorization/authorization-data.service';
+import {AuthService} from '../../../../../core/auth/auth.service';
 
 const allowedPreviewFormats = ['text/plain', 'text/html', 'application/zip', 'application/x-tar'];
 @Component({
@@ -29,10 +29,14 @@ export class FileDescriptionComponent implements OnInit {
   @Input()
   fileInput: MetadataBitstream;
 
+  @ViewChild('videoPreview') videoElement: ElementRef;
+
   emailToContact: string;
   content_url$: Observable<string>;
   content_url: string;
   thumbnail_url$: Observable<string>;
+  handlers_added = false;
+  playPromise: Promise<void>;
 
   constructor(protected halService: HALEndpointService,
               private router: Router,
@@ -50,14 +54,14 @@ export class FileDescriptionComponent implements OnInit {
     });
     this.content_url$ = this.bitstreamService.findById(this.fileInput.id, true, false, followLink('thumbnail'))
       .pipe(getFirstCompletedRemoteData(),
-            switchMap((remoteData : RemoteData<Bitstream>) => {
+            switchMap((remoteData: RemoteData<Bitstream>) => {
               if (remoteData.hasSucceeded) {
                 this.thumbnail_url$ = remoteData.payload?.thumbnail.pipe(
                   switchMap((thumbnailRD: RemoteData<Bitstream>) => {
                     if (thumbnailRD.hasSucceeded) {
                       return this.buildUrl(thumbnailRD.payload?._links.content.href);
                     } else {
-                      return of("");
+                      return of('');
                     }
                   }),
                 );
@@ -70,7 +74,6 @@ export class FileDescriptionComponent implements OnInit {
     });
   }
 
-  @ViewChild('videoPreview') videoElement: ElementRef;
   ngAfterViewInit() {
     const video = this.videoElement?.nativeElement;
 
@@ -82,7 +85,7 @@ export class FileDescriptionComponent implements OnInit {
           this.auth.isAuthenticated().pipe(
             switchMap((isLoggedIn) => {
               if (isLoggedIn) {
-                return this.authDataService.isAuthorized(FeatureID.CanDownload, this.content_url.replace('/content', ''))
+                return this.authDataService.isAuthorized(FeatureID.CanDownload, this.content_url.replace('/content', ''));
               } else {
                 return of(false);
               }
@@ -100,8 +103,6 @@ export class FileDescriptionComponent implements OnInit {
     }
   }
 
-  handlers_added = false;
-
   private add_short_lived_token_handling_to_video_playback(video: HTMLVideoElement) {
       if (this.handlers_added) {
         return;
@@ -129,9 +130,6 @@ export class FileDescriptionComponent implements OnInit {
 
     }
 
-
-  playPromise;
-
   private resetSource(currentTime?) {
     const video = this.videoElement?.nativeElement;
     //console.log("networkState in resetSource", video.networkState);
@@ -141,7 +139,9 @@ export class FileDescriptionComponent implements OnInit {
         // don't want to see The play() request was interrupted by...
         // https://developer.chrome.com/blog/play-request-was-interrupted
         this.updateSource(video, currentTime);
-      }).catch(_ => {});
+      }).catch(_ => {
+        //do nothing
+      });
     } else {
       this.updateSource(video, currentTime);
     }
@@ -151,7 +151,7 @@ export class FileDescriptionComponent implements OnInit {
     //console.log("Updating the src");
     this.buildUrl(this.content_url).subscribe(result => {
       video.src = result;
-      if(currentTime) {
+      if (currentTime) {
         video.currentTime = currentTime;
       }
       this.playPromise = video.play();

src/app/item-page/simple/field-components/preview-section/preview-section.component.spec.ts

@@ -43,7 +43,7 @@ describe('PreviewSectionComponent', () => {
 
     // Set up the mock service's getMetadataBitstream method to return a simple stream
     const metadatabitstream = new MetadataBitstream();
-    metadatabitstream.id = 123;
+    metadatabitstream.id = '5974f1cf-f2ef-4e4c-8f6d-85ad6c52efde';
     metadatabitstream.name = 'test';
     metadatabitstream.description = 'test';
     metadatabitstream.fileSize = 1024;