fix: use curl -OJ instead of -o to avoid UTF-8 filename corruption on non-UTF-8 terminals

On Windows terminals using CP850/CP1252, UTF-8 characters in the -o filename
parameter get corrupted when the user pastes the curl command. Using -OJ tells
curl to read the filename from the server's Content-Disposition header instead,
which is handled internally by curl and bypasses terminal encoding entirely.

Author: milanmajchrak

src/app/item-page/clarin-files-section/clarin-files-section.component.spec.ts

@@ -108,7 +108,7 @@ describe('ClarinFilesSectionComponent', () => {
       component.listOfFiles.next([createMetadataBitstream('simple.txt')]);
       component.generateCurlCommand();
       expect(component.command).toBe(
-        `curl -o "simple.txt" "${BASE}/123456789/1/simple.txt"`
+        `curl -OJ "${BASE}/123456789/1/simple.txt"`
       );
     });
 
@@ -120,26 +120,26 @@ describe('ClarinFilesSectionComponent', () => {
       ]);
       component.generateCurlCommand();
       expect(component.command).toBe(
-        `curl -o "file1.txt" "${BASE}/123456789/2/file1.txt" ` +
-        `-o "file2.txt" "${BASE}/123456789/2/file2.txt"`
+        `curl -OJ "${BASE}/123456789/2/file1.txt" ` +
+        `-OJ "${BASE}/123456789/2/file2.txt"`
       );
     });
 
-    it('should percent-encode spaces in URL but keep real name in -o', () => {
+    it('should percent-encode spaces in URL', () => {
       component.itemHandle = '123456789/3';
       component.listOfFiles.next([createMetadataBitstream('my file.txt')]);
       component.generateCurlCommand();
       expect(component.command).toBe(
-        `curl -o "my file.txt" "${BASE}/123456789/3/my%20file.txt"`
+        `curl -OJ "${BASE}/123456789/3/my%20file.txt"`
       );
     });
 
-    it('should percent-encode parentheses in URL but keep real name in -o', () => {
+    it('should percent-encode parentheses in URL', () => {
       component.itemHandle = '123456789/4';
       component.listOfFiles.next([createMetadataBitstream('logo (2).png')]);
       component.generateCurlCommand();
       expect(component.command).toBe(
-        `curl -o "logo (2).png" "${BASE}/123456789/4/logo%20%282%29.png"`
+        `curl -OJ "${BASE}/123456789/4/logo%20%282%29.png"`
       );
     });
 
@@ -148,7 +148,7 @@ describe('ClarinFilesSectionComponent', () => {
       component.listOfFiles.next([createMetadataBitstream('dtq+logo.png')]);
       component.generateCurlCommand();
       expect(component.command).toBe(
-        `curl -o "dtq+logo.png" "${BASE}/123456789/5/dtq%2Blogo.png"`
+        `curl -OJ "${BASE}/123456789/5/dtq%2Blogo.png"`
       );
     });
 
@@ -160,26 +160,26 @@ describe('ClarinFilesSectionComponent', () => {
       ]);
       component.generateCurlCommand();
       expect(component.command).toBe(
-        `curl -o "dtq+logo (2).png" "${BASE}/123456789/6/dtq%2Blogo%20%282%29.png" ` +
-        `-o "Screenshot 1.png" "${BASE}/123456789/6/Screenshot%201.png"`
+        `curl -OJ "${BASE}/123456789/6/dtq%2Blogo%20%282%29.png" ` +
+        `-OJ "${BASE}/123456789/6/Screenshot%201.png"`
       );
     });
 
-    it('should preserve UTF-8 characters in -o filename and encode in URL', () => {
+    it('should percent-encode UTF-8 characters in URL', () => {
       component.itemHandle = '123456789/9';
       component.listOfFiles.next([createMetadataBitstream('M\u00e9di\u00e1 (3).jfif')]);
       component.generateCurlCommand();
       expect(component.command).toBe(
-        `curl -o "M\u00e9di\u00e1 (3).jfif" "${BASE}/123456789/9/M%C3%A9di%C3%A1%20%283%29.jfif"`
+        `curl -OJ "${BASE}/123456789/9/M%C3%A9di%C3%A1%20%283%29.jfif"`
       );
     });
 
-    it('should escape double quotes in filenames', () => {
+    it('should percent-encode double quotes in URL', () => {
       component.itemHandle = '123456789/10';
       component.listOfFiles.next([createMetadataBitstream('file "quoted".txt')]);
       component.generateCurlCommand();
       expect(component.command).toBe(
-        `curl -o "file \\"quoted\\".txt" "${BASE}/123456789/10/file%20%22quoted%22.txt"`
+        `curl -OJ "${BASE}/123456789/10/file%20%22quoted%22.txt"`
       );
     });
 
@@ -204,7 +204,7 @@ describe('ClarinFilesSectionComponent', () => {
       component.listOfFiles.next([createMetadataBitstream('100% done.txt')]);
       component.generateCurlCommand();
       expect(component.command).toBe(
-        `curl -o "100% done.txt" "${BASE}/123456789/11/100%25%20done.txt"`
+        `curl -OJ "${BASE}/123456789/11/100%25%20done.txt"`
       );
     });
 
@@ -213,7 +213,7 @@ describe('ClarinFilesSectionComponent', () => {
       component.listOfFiles.next([createMetadataBitstream('M\u00e9di\u00e1 (+)#9) ano')]);
       component.generateCurlCommand();
       expect(component.command).toBe(
-        `curl -o "M\u00e9di\u00e1 (+)#9) ano" "${BASE}/123456789/12/M%C3%A9di%C3%A1%20%28%2B%29%239%29%20ano"`
+        `curl -OJ "${BASE}/123456789/12/M%C3%A9di%C3%A1%20%28%2B%29%239%29%20ano"`
       );
     });
 
@@ -228,12 +228,12 @@ describe('ClarinFilesSectionComponent', () => {
       expect(component.canShowCurlDownload).toBeFalse();
     });
 
-    it('should escape dollar signs and backticks in filenames for shell safety', () => {
+    it('should percent-encode dollar signs in URL', () => {
       component.itemHandle = '123456789/14';
       component.listOfFiles.next([createMetadataBitstream('price$100.txt')]);
       component.generateCurlCommand();
       expect(component.command).toBe(
-        `curl -o "price\\$100.txt" "${BASE}/123456789/14/price%24100.txt"`
+        `curl -OJ "${BASE}/123456789/14/price%24100.txt"`
       );
     });
   });

src/app/item-page/clarin-files-section/clarin-files-section.component.ts

@@ -121,17 +121,16 @@ export class ClarinFilesSectionComponent implements OnInit {
       return file.name;
     });
 
-    // Generate curl command with -o "filename" "url" pairs for each file.
-    // Each file needs its own -o + URL pair because curl URL globbing ({})
-    // does NOT support per-file -o flags (multiple -o with {} results in
-    // "Got more output options than URLs" and only the first file is saved).
-    // Using -o lets the shell pass the real filename (including UTF-8) directly.
+    // Generate curl command with -OJ per URL. The -O flag tells curl to use the
+    // remote name and -J (--remote-header-name) tells it to use the filename from
+    // the server's Content-Disposition header instead. This avoids placing non-ASCII
+    // filenames directly in the shell command, which breaks on terminals that don't
+    // use UTF-8 encoding (e.g. Windows CP850/CP1252 corrupts the bytes).
     const baseUrl = `${this.halService.getRootHref()}/core/bitstreams/handle/${this.itemHandle}`;
     const parts = fileNames.map(name => {
       const encodedName = encodeURIComponent(name)
         .replace(/[()]/g, c => '%' + c.charCodeAt(0).toString(16).toUpperCase());
-      const safeName = name.replace(/\\/g, '\\\\').replace(/"/g, '\\"').replace(/\$/g, '\\$').replace(/`/g, '\\`');
-      return `-o "${safeName}" "${baseUrl}/${encodedName}"`;
+      return `-OJ "${baseUrl}/${encodedName}"`;
     });
     this.command = `curl ${parts.join(' ')}`;
   }