Skip to content

Commit a7a807c

Browse files
tdonohuegithub-actions[bot]
authored andcommitted
Enable excessibility checking of login menu, and remove unnecessary exclusion from header
(cherry picked from commit 339ed63)
1 parent baecf2a commit a7a807c

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

cypress/e2e/header.cy.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ describe('Header', () => {
1111
testA11y({
1212
include: ['ds-header'],
1313
exclude: [
14-
['#search-navbar-container'], // search in navbar has duplicative ID. Will be fixed in #1174
15-
['.dropdownLogin'] // "Log in" link has color contrast issues. Will be fixed in #1149
14+
['#search-navbar-container'] // search in navbar has duplicative ID. Will be fixed in #1174
1615
],
1716
});
1817
});

cypress/e2e/login-modal.cy.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { TEST_ADMIN_PASSWORD, TEST_ADMIN_USER, TEST_ENTITY_PUBLICATION } from 'cypress/support/e2e';
2+
import { testA11y } from 'cypress/support/utils';
23

34
const page = {
45
openLoginMenu() {
@@ -123,4 +124,15 @@ describe('Login Modal', () => {
123124
cy.location('pathname').should('eq', '/forgot');
124125
cy.get('ds-forgot-email').should('exist');
125126
});
127+
128+
it('should pass accessibility tests', () => {
129+
cy.visit('/');
130+
131+
page.openLoginMenu();
132+
133+
cy.get('ds-log-in').should('exist');
134+
135+
// Analyze <ds-log-in> for accessibility issues
136+
testA11y('ds-log-in');
137+
});
126138
});

0 commit comments

Comments
 (0)