Skip to content

Commit 18b0bbd

Browse files
author
Matus Kasak
committed
fix: remove unused baseId param from release in UniqueIdRegistry
1 parent 6142afe commit 18b0bbd

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/app/shared/form/builder/ds-dynamic-form-ui/ds-dynamic-form-control-container.component.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ export class DsDynamicFormControlContainerComponent extends DynamicFormControlCo
215215
/**
216216
* The unique element ID assigned to this component instance.
217217
* For the first occurrence of a base ID, this equals the base ID (preserving backward compatibility).
218-
* For subsequent occurrences, a numeric suffix is appended (e.g., `baseId_1`, `baseId_2`).
218+
* For subsequent occurrences, a numeric suffix is appended.
219219
*/
220220
private _uniqueId: string;
221221

@@ -270,8 +270,8 @@ export class DsDynamicFormControlContainerComponent extends DynamicFormControlCo
270270

271271
/**
272272
* Returns a unique element ID for this component instance.
273-
* The first occurrence of a base ID keeps the original value (e.g., `dc_title`).
274-
* Subsequent occurrences receive a numeric suffix (e.g., `metashare_..._mediaType_1`).
273+
* The first occurrence of a base ID keeps the original value.
274+
* Subsequent occurrences receive a numeric suffix.
275275
*/
276276
get id(): string {
277277
if (!this._uniqueId) {
@@ -532,7 +532,7 @@ export class DsDynamicFormControlContainerComponent extends DynamicFormControlCo
532532
ngOnDestroy(): void {
533533
if (this._uniqueId && this._baseId) {
534534
const instanceKey = `${this._baseId}_${this.model?.parent?.id || 'root'}`;
535-
UniqueIdRegistry.release(this._baseId, instanceKey);
535+
UniqueIdRegistry.release(instanceKey);
536536
}
537537
this.subs
538538
.filter((sub) => hasValue(sub))

src/app/shared/form/builder/ds-dynamic-form-ui/models/scrollable-dropdown/dynamic-scrollable-dropdown.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ export class DsDynamicScrollableDropdownComponent extends DsDynamicVocabularyCom
324324
ngOnDestroy(): void {
325325
if (this._uniqueId && this._baseId) {
326326
const instanceKey = `${this._baseId}_${this.model?.parent?.id || 'root'}`;
327-
UniqueIdRegistry.release(this._baseId, instanceKey);
327+
UniqueIdRegistry.release(instanceKey);
328328
}
329329
}
330330

0 commit comments

Comments
 (0)