Get-DbaDbCompression: Add DatabaseId to the return object #8769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niphlod
approved these changes
Feb 21, 2023
wsmelton
requested changes
Feb 26, 2023
tests/Get-DbaDbCompression.Tests.ps1
Outdated
| $server = Connect-DbaInstance -SqlInstance $script:instance2 | ||
| $null = $server.Query("Create Database [$dbname]") | ||
| $db = New-DbaDatabase -SqlInstance $script:instance2 -Database $dbname |
There was a problem hiding this comment.
Please revert this line, no reason to include another module command in this test. Issuing the T-SQL command is much simpler.
tests/Get-DbaDbCompression.Tests.ps1
Outdated
| $null = $server.Query("select * into syscols from sys.all_columns | ||
| select * into sysallparams from sys.all_parameters | ||
| create clustered index CL_sysallparams on sysallparams (object_id) | ||
| create nonclustered index NC_syscols on syscols (precision) include (collation_name)", $dbname) | ||
| } | ||
| AfterAll { | ||
| Get-DbaProcess -SqlInstance $script:instance2 -Database $dbname | Stop-DbaProcess -WarningAction SilentlyContinue | ||
| Remove-DbaDatabase -SqlInstance $script:instance2 -Database $dbname -Confirm:$false | ||
| $db | Remove-DbaDatabase -Confirm:$false |
wsmelton
reviewed
Feb 27, 2023
| @@ -32,8 +32,10 @@ Describe "$commandname Integration Tests" -Tags "IntegrationTests" { | |||
| Context "Command handles heaps and clustered indexes" { | |||
| It "Gets results" { | |||
| $results | Should Not Be $null | |||
| $results.Database | Get-Unique | Should -Be $dbname | |||
| $results.DatabaseId | Get-Unique | Should -Be $server.Query("SELECT database_id FROM sys.databases WHERE name = '$dbname'").database_id | |||
There was a problem hiding this comment.
Believe this only works because we are still on Pester v4 in v5 it won't execute script commands found in the It block and would always fail. Do not have to change now because this test alone will have to be reworked anyway if we ever get around to converting to v5.
|
Thank you both 🙇🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read -- recent changes to our repo
On November 10, 2022, we removed some bloat from our repository (for the second and final time). This change requires that all contributors reclone or refork their repo.
PRs from repos that have not been recently reforked or recloned will be closed and @potatoqualitee will cherry-pick your commits and open a new PR with your changes.
Type of Change
.\tests\manual.pester.ps1)Purpose
Minor change to add DatabaseId to the return object.
Commands to test
See current Pester tests for this command.