Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get dba db sequence #7296

Merged
merged 5 commits into from
May 14, 2021
Merged

Get dba db sequence #7296

merged 5 commits into from
May 14, 2021

Conversation

MikeyBronowski
Copy link
Contributor

@MikeyBronowski MikeyBronowski commented May 7, 2021 •
edited
Loading

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes Get-DbaDbSequence Remove requirement to provide the name, database, etc - more fexible #7295 )
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

#7295

Approach

Follow the solution in Get-DbaDbRole

Commands to test

Screenshots

Learning

@MikeyBronowski MikeyBronowski marked this pull request as ready for review May 7, 2021 22:02
jpomfret
jpomfret approved these changes May 14, 2021
View reviewed changes
Copy link
Collaborator

@jpomfret jpomfret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - good change - thanks!

@jpomfret jpomfret merged commit 2d386f8 into dataplat:development May 14, 2021
@MikeyBronowski MikeyBronowski deleted the Get-DbaDbSequence branch May 14, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpomfret jpomfret jpomfret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get-DbaDbSequence Remove requirement to provide the name, database, etc - more fexible
2 participants
@MikeyBronowski @jpomfret