Remove XESmartTarget Commands and Fix DAC (#9783)

Author: potatoqualitee

.github/dbatools-library-version.json

@@ -1,4 +1,4 @@
 {
-  "version": "2025.8.5",
+  "version": "2025.8.17-preview-dac-20250817060550",
   "notes": "Version of dbatools.library to use for CI/CD and development"
 }

.github/workflows/gallery.yml

@@ -7,6 +7,7 @@ on:
    paths-ignore:
      - '**/*.md'
      - '**/*.json'
+     - '!.github/dbatools-library-version.json'
      - 'docs/**'
      - '.github/FUNDING.yml'
      - '.github/ISSUE_TEMPLATE/**'

.github/workflows/integration-tests-repl.yml

@@ -4,6 +4,7 @@ on:
     paths-ignore:
       - '**/*.md'
       - '**/*.json'
+      - '!.github/dbatools-library-version.json'
       - 'docs/**'
       - '.github/FUNDING.yml'
       - '.github/ISSUE_TEMPLATE/**'

.github/workflows/integration-tests.yml

@@ -4,6 +4,7 @@ on:
     paths-ignore:
       - '**/*.md'
       - '**/*.json'
+      - '!.github/dbatools-library-version.json'
       - 'docs/**'
       - '.github/FUNDING.yml'
       - '.github/ISSUE_TEMPLATE/**'
@@ -56,20 +57,15 @@ jobs:
           Write-Output "Preview version detected, bypassing PSModuleCache and using install script"
           ./.github/scripts/install-dbatools-library.ps1
 
-      - name: Check file health and set encryption values
+      - name: Set encryption values
         run: |
           Import-Module ./dbatools.psd1 -Force
           Get-Module dbatools.library | Select-Object -ExpandProperty Path -OutVariable lib | Write-Warning
-          $lib = Split-Path -Path $lib -Parent
-          Get-ChildItem (Join-Path $lib -ChildPath core/lib/dac/linux) | Write-Warning
           Set-DbatoolsConfig -FullName sql.connection.trustcert -Value $true -Register
           Set-DbatoolsConfig -FullName sql.connection.encrypt -Value $false -Register
           Get-DbatoolsConfigValue -FullName sql.connection.encrypt | Write-Warning
           mkdir /tmp/DbatoolsExport
 
-      - name: Ensure sqlpackage is executable
-        run: chmod +x /home/runner/.local/share/powershell/Modules/dbatools.library/core/lib/dac/linux/sqlpackage || true
-
       - name:  Setup docker images
         run: |
           # create a shared network
@@ -84,15 +80,11 @@ jobs:
         run: |
           gh repo clone dataplat/appveyor-lab
 
-      - name: Install SqlPackage for DAC tests
-        run: |
-          Import-Module ./dbatools.psd1 -Force
-          Install-DbaSqlPackage -Verbose
-
-      - name: Install XESmartTarget for Extended Events tests
+      - name: Install SqlPackage
+        shell: pwsh
         run: |
           Import-Module ./dbatools.psd1 -Force
-          Install-DbaXESmartTarget -Force
+          Install-DbaSqlPackage -Force -Verbose
 
       - name: Run tests
         env:
@@ -172,17 +164,11 @@ jobs:
           $PSDefaultParameterValues["*:SqlCredential"] = $cred
           Connect-DbaInstance
 
-      - name: Install SqlPackage for DAC tests (PowerShell)
-        shell: powershell
-        run: |
-          Import-Module ./dbatools -Force
-          Install-DbaSqlPackage -Verbose
-
-      - name: Install XESmartTarget for Extended Events tests (PowerShell)
-        shell: powershell
+      - name: Install SqlPackage
+        shell: pwsh
         run: |
-          Import-Module ./dbatools -Force
-          Install-DbaXESmartTarget -Force
+          Import-Module ./dbatools.psd1 -Force
+          Install-DbaSqlPackage -Force -Verbose
 
       - name: Run PowerShell tests
         env:
@@ -192,18 +178,6 @@ jobs:
         shell: powershell
         run: $null = Invoke-Pester .github/scripts/gh-winactions.ps1 -Output Detailed -PassThru
 
-      - name: Install SqlPackage for DAC tests (pwsh)
-        shell: pwsh
-        run: |
-          Import-Module ./dbatools -Force
-          Install-DbaSqlPackage -Verbose
-
-      - name: Install XESmartTarget for Extended Events tests (pwsh)
-        shell: pwsh
-        run: |
-          Import-Module ./dbatools -Force
-          Install-DbaXESmartTarget -Force
-
       - name: Run pwsh tests
         env:
           TENANTID: ${{secrets.TENANTID}}
@@ -254,6 +228,12 @@ jobs:
         run: |
           gh repo clone dataplat/appveyor-lab
 
+      - name: Install SqlPackage
+        shell: pwsh
+        run: |
+          Import-Module ./dbatools.psd1 -Force
+          Install-DbaSqlPackage -Force -Verbose
+
       - name: Run macOS tests
         env:
           TENANTID: ${{secrets.TENANTID}}

.github/workflows/xplat-import.yml

@@ -4,6 +4,7 @@ on:
     paths-ignore:
       - '**/*.md'
       - '**/*.json'
+      - '!.github/dbatools-library-version.json'
       - 'docs/**'
       - '.github/FUNDING.yml'
       - '.github/ISSUE_TEMPLATE/**'

appveyor.yml

@@ -9,6 +9,7 @@ skip_commits:
   files:
     - '**/*.md'
     - '**/*.json'
+    - '!.github/dbatools-library-version.json'
     - 'docs/**'
     - '.github/FUNDING.yml'
     - '.github/ISSUE_TEMPLATE/**'

dbatools.psd1

@@ -149,7 +149,6 @@
         'Export-DbaSysDbUserObject',
         'Export-DbatoolsConfig',
         'Export-DbaUser',
-        'Export-DbaXECsv',
         'Export-DbaXESession',
         'Export-DbaXESessionTemplate',
         'Find-DbaAgentJob',
@@ -409,7 +408,6 @@
         'Get-DbaXESessionTarget',
         'Get-DbaXESessionTargetFile',
         'Get-DbaXESessionTemplate',
-        'Get-DbaXESmartTarget',
         'Get-DbaXEStore',
         'Grant-DbaAgPermission',
         'Import-DbaCsv',
@@ -426,7 +424,6 @@
         'Install-DbaSqlPackage',
         'Install-DbaSqlWatch',
         'Install-DbaWhoIsActive',
-        'Install-DbaXESmartTarget',
         'Invoke-DbaDbAzSqlTip',
         'Invoke-DbaAdvancedInstall',
         'Invoke-DbaAdvancedRestore',
@@ -517,11 +514,6 @@
         'New-DbaSqlParameter',
         'New-DbatoolsSupportPackage',
         'New-DbaXESession',
-        'New-DbaXESmartCsvWriter',
-        'New-DbaXESmartEmail',
-        'New-DbaXESmartQueryExec',
-        'New-DbaXESmartReplay',
-        'New-DbaXESmartTableWriter',
         'Publish-DbaDacPackage',
         'Read-DbaAuditFile',
         'Read-DbaBackupHeader',
@@ -580,7 +572,6 @@
         'Remove-DbaSpn',
         'Remove-DbaTrace',
         'Remove-DbaXESession',
-        'Remove-DbaXESmartTarget',
         'Rename-DbaDatabase',
         'Rename-DbaLogin',
         'Repair-DbaDbMirror',
@@ -651,7 +642,6 @@
         'Start-DbaService',
         'Start-DbaTrace',
         'Start-DbaXESession',
-        'Start-DbaXESmartTarget',
         'Stop-DbaAgentJob',
         'Stop-DbaEndpoint',
         'Stop-DbaExternalProcess',
@@ -660,7 +650,6 @@
         'Stop-DbaService',
         'Stop-DbaTrace',
         'Stop-DbaXESession',
-        'Stop-DbaXESmartTarget',
         'Suspend-DbaAgDbDataMovement',
         'Sync-DbaAvailabilityGroup',
         'Sync-DbaLoginPermission',

dbatools.psm1

@@ -566,8 +566,6 @@ if ($PSVersionTable.PSVersion.Major -lt 5) {
         'New-DbaAgentProxy',
         'Test-DbaDbLogShipStatus',
         'Get-DbaXESessionTarget',
-        'New-DbaXESmartTargetResponse',
-        'New-DbaXESmartTarget',
         'Get-DbaDbVirtualLogFile',
         'Get-DbaBackupInformation',
         'Start-DbaXESession',
@@ -597,11 +595,6 @@ if ($PSVersionTable.PSVersion.Major -lt 5) {
         'Remove-DbaXESession',
         'New-DbaXESession',
         'Get-DbaXEStore',
-        'New-DbaXESmartTableWriter',
-        'New-DbaXESmartReplay',
-        'New-DbaXESmartEmail',
-        'New-DbaXESmartQueryExec',
-        'Start-DbaXESmartTarget',
         'Get-DbaDbOrphanUser',
         'Get-DbaOpenTransaction',
         'Get-DbaDbLogShipError',
@@ -616,13 +609,9 @@ if ($PSVersionTable.PSVersion.Major -lt 5) {
         'Get-DbaXEObject',
         'ConvertTo-DbaDataTable',
         'Find-DbaDbDisabledIndex',
-        'Get-DbaXESmartTarget',
-        'Remove-DbaXESmartTarget',
-        'Stop-DbaXESmartTarget',
         'Get-DbaRegServerGroup',
         'New-DbaDbUser',
         'Measure-DbaDiskSpaceRequirement',
-        'New-DbaXESmartCsvWriter',
         'Invoke-DbaXeReplay',
         'Find-DbaInstance',
         'Test-DbaDiskSpeed',
@@ -810,7 +799,6 @@ if ($PSVersionTable.PSVersion.Major -lt 5) {
         'Install-DbaFirstResponderKit',
         'Install-DbaSqlPackage',
         'Install-DbaWhoIsActive',
-        'Install-DbaXESmartTarget',
         'Update-Dbatools',
         'Add-DbaServerRoleMember',
         'Get-DbatoolsPath',
@@ -941,7 +929,6 @@ if ($PSVersionTable.PSVersion.Major -lt 5) {
         'Add-DbaPfDataCollectorCounter',
         'Remove-DbaPfDataCollectorCounter',
         'Get-DbaPfAvailableCounter',
-        'Export-DbaXECsv',
         'Get-DbaOperatingSystem',
         'Get-DbaComputerSystem',
         'Set-DbaPrivilege',