-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Various improvements to the CLI endpoints #441
Conversation
Codecov Report
@@ Coverage Diff @@
## main #441 +/- ##
==========================================
- Coverage 65.37% 64.61% -0.76%
==========================================
Files 92 93 +1
Lines 8253 8404 +151
==========================================
+ Hits 5395 5430 +35
- Misses 2858 2974 +116
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: WenkelF <frederik.wenkel@cn-g013.server.mila.quebec>
Let me also try credit @WenkelF properly again. Co-authored-by: WenkelF <frederik.wenkel@gmail.com>
Co-authored-by: WenkelF <frederik.wenkel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a comment about the CLI for fingerprinting. Seems to miss the ability to chose a dataset?? Or does that come from the config?
* `--inclusive-filter / --no-inclusive-filter`: [default: inclusive-filter] | ||
* `--help`: Show this message and exit. | ||
|
||
### `graphium finetune fingerprint` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you specify which dataset you want to generate the fingerprints on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comes from the config! It uses the predict_dataloader()
of the datamodule, which in Graphium has been implemented to fallback to the test_dataloader
if not explicitly specified.
Changelogs
.ckpt
path, instead of always relying on a manually defined mapping in thespaces.py
.graphium-prepare-data
command in favor of a new subcommand at:graphium data prepare
.graphium finetune fingerprint
to easily extract fingerprints from a model.Checklist:
Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.feature
,fix
ortest
(or ask a maintainer to do it for you).discussion related to that PR