Skip to content
This repository was archived by the owner on Apr 17, 2018. It is now read-only.

Commit 0883bf4

Browse files
committed
[all java] Move JRuby extensions into namespaced dir.
* Respect Ruby load path and don't keep .jar files in lib/ but in properly-namespaced subdirectory. * Has the knock-on effect of no longer using the base package in our Java classes. Signed-off-by: Alex Coles <alex@alexcolesportfolio.com>
1 parent b88c53d commit 0883bf4

File tree

25 files changed

+61
-16
lines changed

25 files changed

+61
-16
lines changed

do_derby/ext-java/src/main/java/DoDerbyExtService.java renamed to do_derby/ext-java/src/main/java/do_derby/DoDerbyExtService.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1+
package do_derby;
2+
3+
import data_objects.drivers.AbstractDataObjectsExtService;
14
import data_objects.drivers.DriverDefinition;
2-
import do_derby.DerbyDriverDefinition;
35

46
public class DoDerbyExtService extends AbstractDataObjectsExtService {
57

do_derby/lib/do_derby.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
require 'jdbc/derby' # the JDBC driver, packaged as a gem
1212
end
1313

14-
require 'do_derby_ext' # the Java extension for this DO driver
14+
require 'do_derby/do_derby_ext' # the Java extension for this DO driver
1515

1616
# Another way of loading the JDBC Class. This seems to be more reliable
1717
# than Class.forName() within the data_objects.Connection Java class,

do_derby/tasks/compile.rake

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ begin
1111

1212
Rake::JavaExtensionTask.new('do_derby_ext', gemspec) do |ext|
1313
ext.ext_dir = 'ext-java/src/main/java'
14+
ext.lib_dir = 'lib/do_derby'
1415
ext.debug = ENV.has_key?('DO_JAVA_DEBUG') && ENV['DO_JAVA_DEBUG']
1516
ext.classpath = '../do_jdbc/lib/do_jdbc_internal.jar'
1617
ext.java_compiling do |gem_spec|

do_h2/ext-java/src/main/java/DoH2ExtService.java renamed to do_h2/ext-java/src/main/java/do_h2/DoH2ExtService.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1+
package do_h2;
2+
3+
import data_objects.drivers.AbstractDataObjectsExtService;
14
import data_objects.drivers.DriverDefinition;
2-
import do_h2.H2DriverDefinition;
35

46
public class DoH2ExtService extends AbstractDataObjectsExtService {
57

do_h2/lib/do_h2.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
require 'jdbc/h2' # the JDBC driver, packaged as a gem
1313
end
1414

15-
require 'do_h2_ext' # the Java extension for this DO driver
15+
require 'do_h2/do_h2_ext' # the Java extension for this DO driver
1616

1717
# Another way of loading the JDBC Class. This seems to be more reliable
1818
# than Class.forName() within the data_objects.Connection Java class,

do_h2/tasks/compile.rake

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ begin
1111

1212
Rake::JavaExtensionTask.new('do_h2_ext', gemspec) do |ext|
1313
ext.ext_dir = 'ext-java/src/main/java'
14+
ext.lib_dir = 'lib/do_h2'
1415
ext.debug = ENV.has_key?('DO_JAVA_DEBUG') && ENV['DO_JAVA_DEBUG']
1516
ext.classpath = '../do_jdbc/lib/do_jdbc_internal.jar'
1617
ext.java_compiling do |gem_spec|

do_hsqldb/ext-java/src/main/java/DoHsqldbExtService.java renamed to do_hsqldb/ext-java/src/main/java/do_hsqldb/DoHsqldbExtService.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1+
package do_hsqldb;
2+
3+
import data_objects.drivers.AbstractDataObjectsExtService;
14
import data_objects.drivers.DriverDefinition;
2-
import do_hsqldb.HsqldbDriverDefinition;
35

46
public class DoHsqldbExtService extends AbstractDataObjectsExtService {
57

do_hsqldb/lib/do_hsqldb.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
rescue
1111
require 'jdbc/hsqldb' # the JDBC driver, packaged as a gem
1212
end
13-
require 'do_hsqldb_ext' # the Java extension for this DO driver
13+
require 'do_hsqldb/do_hsqldb_ext' # the Java extension for this DO driver
1414

1515
# Another way of loading the JDBC Class. This seems to be more reliable
1616
# than Class.forName() within the data_objects.Connection Java class,

do_hsqldb/tasks/compile.rake

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ begin
1111

1212
Rake::JavaExtensionTask.new('do_hsqldb_ext', gemspec) do |ext|
1313
ext.ext_dir = 'ext-java/src/main/java'
14+
ext.lib_dir = 'lib/do_hsqldb'
1415
ext.debug = ENV.has_key?('DO_JAVA_DEBUG') && ENV['DO_JAVA_DEBUG']
1516
ext.classpath = '../do_jdbc/lib/do_jdbc_internal.jar'
1617
ext.java_compiling do |gem_spec|

do_jdbc/src/main/java/AbstractDataObjectsExtService.java renamed to do_jdbc/src/main/java/data_objects/drivers/AbstractDataObjectsExtService.java

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
package data_objects.drivers;
2+
13

24
import data_objects.Command;
35
import data_objects.Connection;

do_mysql/ext-java/src/main/java/DoMysqlExtService.java renamed to do_mysql/ext-java/src/main/java/do_mysql/DoMysqlExtService.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1+
package do_mysql;
2+
3+
import data_objects.drivers.AbstractDataObjectsExtService;
14
import data_objects.drivers.DriverDefinition;
2-
import do_mysql.MySqlDriverDefinition;
35

46
public class DoMysqlExtService extends AbstractDataObjectsExtService {
57

do_mysql/lib/do_mysql.rb

+6-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,12 @@
1919

2020
end
2121

22-
require 'do_mysql_ext'
22+
if RUBY_PLATFORM == /java/
23+
require 'do_mysql/do_mysql_ext'
24+
else
25+
# FIXME: Will be changed for MRI
26+
require 'do_mysql_ext'
27+
end
2328
require 'do_mysql/version'
2429
require 'do_mysql/transaction' if RUBY_PLATFORM !~ /java/
2530
require 'do_mysql/encoding'

do_mysql/tasks/compile.rake

+1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ begin
2929

3030
Rake::JavaExtensionTask.new('do_mysql_ext', gemspec) do |ext|
3131
ext.ext_dir = 'ext-java/src/main/java'
32+
ext.lib_dir = 'lib/do_mysql'
3233
ext.debug = ENV.has_key?('DO_JAVA_DEBUG') && ENV['DO_JAVA_DEBUG']
3334
ext.classpath = '../do_jdbc/lib/do_jdbc_internal.jar'
3435
ext.java_compiling do |gem|

do_oracle/ext-java/src/main/java/DoOracleExtService.java renamed to do_oracle/ext-java/src/main/java/do_oracle/DoOracleExtService.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1+
package do_oracle;
2+
3+
import data_objects.drivers.AbstractDataObjectsExtService;
14
import data_objects.drivers.DriverDefinition;
2-
import do_oracle.OracleDriverDefinition;
35

46
public class DoOracleExtService extends AbstractDataObjectsExtService {
57

do_oracle/lib/do_oracle.rb

+6-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,12 @@
77
require 'oci8'
88
end
99

10-
require 'do_oracle_ext'
10+
if RUBY_PLATFORM == /java/
11+
require 'do_oracle/do_oracle_ext'
12+
else
13+
# FIXME: Will be changed for MRI
14+
require 'do_oracle_ext'
15+
end
1116
require File.expand_path(File.join(File.dirname(__FILE__), 'do_oracle', 'version'))
1217

1318
if RUBY_PLATFORM =~ /java/

do_oracle/tasks/compile.rake

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ begin
2525

2626
Rake::JavaExtensionTask.new('do_oracle_ext', gemspec) do |ext|
2727
ext.ext_dir = 'ext-java/src/main/java'
28+
ext.lib_dir = 'lib/do_oracle'
2829
ext.debug = ENV.has_key?('DO_JAVA_DEBUG') && ENV['DO_JAVA_DEBUG']
2930
ext.classpath = '../do_jdbc/lib/do_jdbc_internal.jar'
3031
ext.java_compiling do |gem|

do_postgres/ext-java/src/main/java/DoPostgresExtService.java renamed to do_postgres/ext-java/src/main/java/do_postgres/DoPostgresExtService.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1+
package do_postgres;
2+
3+
import data_objects.drivers.AbstractDataObjectsExtService;
14
import data_objects.drivers.DriverDefinition;
2-
import do_postgres.PostgresDriverDefinition;
35

46
public class DoPostgresExtService extends AbstractDataObjectsExtService {
57

do_postgres/lib/do_postgres.rb

+6-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,12 @@
1717

1818
end
1919

20-
require 'do_postgres_ext'
20+
if RUBY_PLATFORM == /java/
21+
require 'do_postgres/do_postgres_ext'
22+
else
23+
# FIXME: Will be changed for MRI
24+
require 'do_postgres_ext'
25+
end
2126
require 'do_postgres/version'
2227
require 'do_postgres/transaction' if RUBY_PLATFORM !~ /java/
2328
require 'do_postgres/encoding'

do_postgres/tasks/compile.rake

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ begin
3333

3434
Rake::JavaExtensionTask.new('do_postgres_ext', gemspec) do |ext|
3535
ext.ext_dir = 'ext-java/src/main/java'
36+
ext.lib_dir = 'lib/do_postgres'
3637
ext.debug = ENV.has_key?('DO_JAVA_DEBUG') && ENV['DO_JAVA_DEBUG']
3738
ext.classpath = '../do_jdbc/lib/do_jdbc_internal.jar'
3839
ext.java_compiling do |gem|

do_sqlite3/ext-java/src/main/java/DoSqlite3ExtService.java renamed to do_sqlite3/ext-java/src/main/java/do_sqlite3/DoSqlite3ExtService.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1+
package do_sqlite3;
12

3+
import data_objects.drivers.AbstractDataObjectsExtService;
24
import data_objects.drivers.DriverDefinition;
3-
import do_sqlite3.Sqlite3DriverDefinition;
45

56
public class DoSqlite3ExtService extends AbstractDataObjectsExtService {
67

do_sqlite3/lib/do_sqlite3.rb

+6-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,12 @@
1818
java_import driver
1919
end
2020

21-
require 'do_sqlite3_ext'
21+
if RUBY_PLATFORM == /java/
22+
require 'do_sqlite3/do_sqlite3_ext'
23+
else
24+
# FIXME: Will be changed for MRI
25+
require 'do_sqlite3_ext'
26+
end
2227
require 'do_sqlite3/version'
2328
require 'do_sqlite3/transaction' if RUBY_PLATFORM !~ /java/
2429

do_sqlite3/tasks/compile.rake

+1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ begin
2727

2828
Rake::JavaExtensionTask.new('do_sqlite3_ext', gemspec) do |ext|
2929
ext.ext_dir = 'ext-java/src/main/java'
30+
ext.lib_dir = 'lib/do_sqlite3'
3031
ext.debug = ENV.has_key?('DO_JAVA_DEBUG') && ENV['DO_JAVA_DEBUG']
3132
ext.classpath = '../do_jdbc/lib/do_jdbc_internal.jar'
3233
ext.java_compiling do |gem|

do_sqlserver/ext-java/src/main/java/DoSqlserverExtService.java renamed to do_sqlserver/ext-java/src/main/java/do_sqlserver/DoSqlserverExtService.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1+
package do_sqlserver;
2+
3+
import data_objects.drivers.AbstractDataObjectsExtService;
14
import data_objects.drivers.DriverDefinition;
2-
import do_sqlserver.SqlServerDriverDefinition;
35

46
// this class must be named DoSqlserverExtService (and not DoSqlServerExtService)
57
// for the extension to be loaded correctly (alternatively, we could add an

do_sqlserver/lib/do_sqlserver.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
require 'bigdecimal'
1313
require 'date'
1414
require 'base64'
15-
require 'do_sqlserver_ext' if RUBY_PLATFORM =~ /java/
15+
require 'do_sqlserver/do_sqlserver_ext' if RUBY_PLATFORM =~ /java/
1616
require 'do_sqlserver/version'
1717
# JDBC driver has transactions implementation in Java
1818
require 'do_sqlserver/transaction' if RUBY_PLATFORM !~ /java/

do_sqlserver/tasks/compile.rake

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ begin
1111

1212
Rake::JavaExtensionTask.new('do_sqlserver_ext', gemspec) do |ext|
1313
ext.ext_dir = 'ext-java/src/main/java'
14+
ext.lib_dir = 'lib/do_sqlserver'
1415
ext.debug = ENV.has_key?('DO_JAVA_DEBUG') && ENV['DO_JAVA_DEBUG']
1516
ext.classpath = '../do_jdbc/lib/do_jdbc_internal.jar'
1617
ext.java_compiling do |gem_spec|

0 commit comments

Comments
 (0)