fix(iter_gitstatus): rectify usage of unsupport untracked=no mode in tests

Disabling untracked reporting is done with the parameter value `None`.
This is uniformly communicated in the docstrings. Only the tests used
and undocumented `'no'` value.

This change removes support for `'no'` and aligns the implementation
with the documentation.

Author: mih

datalad_next/iter_collections/gitstatus.py

@@ -152,7 +152,7 @@ def _yield_dir_items(
         GitTreeItemType.directory,
         GitTreeItemType.submodule,
     )
-    if untracked == 'no':
+    if untracked is None:
         # no need to look at anything other than the diff report
         dir_items = {}
     else:
@@ -191,7 +191,7 @@ def _yield_dir_items(
                 if dir_path.exists():
                     item.add_modification_type(
                         GitContainerModificationType.modified_content)
-                    if untracked != 'no' \
+                    if untracked is not None \
                             and _path_has_untracked(path / item.path):
                         item.add_modification_type(
                             GitContainerModificationType.untracked_content)
@@ -204,7 +204,7 @@ def _yield_dir_items(
         if item.status:
             yield item
 
-    if untracked == 'no':
+    if untracked is None:
         return
 
     # yield anything untracked, and inspect remaining containers
@@ -302,7 +302,7 @@ def _yield_repo_items(
         if item.status:
             yield item
 
-    if untracked == 'no':
+    if untracked is None:
         return
 
     # lastly untracked files of this repo

datalad_next/iter_collections/gitworktree.py

@@ -23,10 +23,7 @@
     decode_bytes,
     itemize,
 )
-from datalad_next.gitpathspec import (
-    GitPathSpec,
-    GitPathSpecs,
-)
+from datalad_next.gitpathspec import GitPathSpecs
 from .utils import (
     FileSystemItem,
     FileSystemItemType,

datalad_next/iter_collections/tests/test_itergitstatus.py

@@ -38,9 +38,9 @@ def test_status_homogeneity(modified_dataset):
         dict(path=ds.pathobj, eval_submodule_state='commit', recursive='repository'),
         dict(path=ds.pathobj, eval_submodule_state='commit', recursive='submodules'),
         # without untracked
-        dict(path=ds.pathobj, untracked='no', recursive='no'),
-        dict(path=ds.pathobj, untracked='no', recursive='repository'),
-        dict(path=ds.pathobj, untracked='no', recursive='submodules'),
+        dict(path=ds.pathobj, untracked=None, recursive='no'),
+        dict(path=ds.pathobj, untracked=None, recursive='repository'),
+        dict(path=ds.pathobj, untracked=None, recursive='submodules'),
         # special untracked modes
         dict(path=ds.pathobj, untracked='whole-dir', recursive='no'),
         dict(path=ds.pathobj, untracked='whole-dir', recursive='repository'),