Skip to content
This repository was archived by the owner on Dec 8, 2023. It is now read-only.

Updates for codebook deployment #78

Merged
merged 12 commits into from
Sep 19, 2022
Merged

Updates for codebook deployment #78

merged 12 commits into from
Sep 19, 2022

Conversation

CBroz1
Copy link
Contributor

@CBroz1 CBroz1 commented Sep 15, 2022

Depends on ephys PR 92

Done:

  • Update paths
  • Add lab.User inserts to ingest.py
  • Remove Curation from notebooks
  • update mounted data
  • Version bump/changelog
  • Add upstream inserts to NWB notebook

Future PRs:

  • plots on notebook 7 display twice. Not a problem, but doesn't look great.

@CBroz1 CBroz1 marked this pull request as ready for review September 16, 2022 19:12
@CBroz1 CBroz1 requested a review from sidhulyalkar September 16, 2022 19:22
@CBroz1 CBroz1 requested a review from drewyangdev September 16, 2022 21:33
@CBroz1
Copy link
Contributor Author

CBroz1 commented Sep 16, 2022

Hi @yambottle - Before we merge, would you take a look at the CICD errors and lmk if there are any issues we should address? It's reporting something about codebook_base_hash I thought you already tackled.

Deadline on this is a demo on Tues. Hopefully we can merge and let the CICD push to codebook Monday

@drewyangdev
Copy link
Contributor

Hi @yambottle - Before we merge, would you take a look at the CICD errors and lmk if there are any issues we should address? It's reporting something about codebook_base_hash I thought you already tackled.

Deadline on this is a demo on Tues. Hopefully we can merge and let the CICD push to codebook Monday

@CBroz1 Can you run:

cd .github
bash make-prod.sh

and then commit?

I realized the staging CICD updated, but not the actual ones

@CBroz1
Copy link
Contributor Author

CBroz1 commented Sep 16, 2022

cd .github
bash make-prod.sh

Looks like it worked - Thanks!!

@sidhulyalkar sidhulyalkar merged commit 3711aec into datajoint:main Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants